-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Disable SSI telemetry by default #6020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6020) - mean (70ms) : 66, 73
. : milestone, 70,
master - mean (75ms) : 66, 84
. : milestone, 75,
section CallTarget+Inlining+NGEN
This PR (6020) - mean (1,105ms) : 1085, 1125
. : milestone, 1105,
master - mean (1,135ms) : 1097, 1172
. : milestone, 1135,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6020) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (117ms) : 108, 127
. : milestone, 117,
section CallTarget+Inlining+NGEN
This PR (6020) - mean (814ms) : 796, 832
. : milestone, 814,
master - mean (837ms) : 811, 863
. : milestone, 837,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6020) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (97ms) : 89, 104
. : milestone, 97,
section CallTarget+Inlining+NGEN
This PR (6020) - mean (768ms) : 752, 784
. : milestone, 768,
master - mean (792ms) : 764, 819
. : milestone, 792,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6020) - mean (190ms) : 187, 194
. : milestone, 190,
master - mean (190ms) : 187, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6020) - mean (1,195ms) : 1168, 1222
. : milestone, 1195,
master - mean (1,195ms) : 1170, 1220
. : milestone, 1195,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6020) - mean (278ms) : 274, 282
. : milestone, 278,
master - mean (278ms) : 272, 284
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (6020) - mean (978ms) : 957, 998
. : milestone, 978,
master - mean (973ms) : 950, 996
. : milestone, 973,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6020) - mean (265ms) : 259, 271
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6020) - mean (951ms) : 925, 977
. : milestone, 951,
master - mean (949ms) : 931, 967
. : milestone, 949,
|
Datadog ReportBranch report: ✅ 0 Failed, 366114 Passed, 2346 Skipped, 16h 26m 8.76s Total Time |
Benchmarks Report for tracer 🐌Benchmarks for #6020 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.126 | 1,473.46 | 1,659.07 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.47μs | 0.631ns | 2.36ns | 0.0229 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.24μs | 1.15ns | 4.44ns | 0.0223 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.61μs | 3.14ns | 12.2ns | 0.249 | 0 | 0 | 1.57 KB |
#6020 | EnrichedLog |
net6.0 | 1.66μs | 0.459ns | 1.66ns | 0.0232 | 0 | 0 | 1.64 KB |
#6020 | EnrichedLog |
netcoreapp3.1 | 2.22μs | 0.947ns | 3.54ns | 0.0221 | 0 | 0 | 1.64 KB |
#6020 | EnrichedLog |
net472 | 2.75μs | 3.36ns | 13ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 114μs | 227ns | 881ns | 0.0571 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 119μs | 201ns | 777ns | 0.0599 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 146μs | 207ns | 802ns | 0.656 | 0.219 | 0 | 4.46 KB |
#6020 | EnrichedLog |
net6.0 | 119μs | 192ns | 743ns | 0.0591 | 0 | 0 | 4.28 KB |
#6020 | EnrichedLog |
netcoreapp3.1 | 120μs | 381ns | 1.47μs | 0 | 0 | 0 | 4.28 KB |
#6020 | EnrichedLog |
net472 | 149μs | 226ns | 876ns | 0.678 | 0.226 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.12μs | 4.19ns | 16.2ns | 0.03 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.08μs | 3.24ns | 12.5ns | 0.0285 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.84μs | 0.827ns | 2.98ns | 0.32 | 0 | 0 | 2.02 KB |
#6020 | EnrichedLog |
net6.0 | 2.97μs | 1.07ns | 4.15ns | 0.0297 | 0 | 0 | 2.2 KB |
#6020 | EnrichedLog |
netcoreapp3.1 | 4.12μs | 1.1ns | 4.25ns | 0.0288 | 0 | 0 | 2.2 KB |
#6020 | EnrichedLog |
net472 | 4.94μs | 3.27ns | 12.7ns | 0.321 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.33μs | 0.571ns | 2.14ns | 0.0159 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.78μs | 0.79ns | 3.06ns | 0.0151 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.15μs | 1.44ns | 5.39ns | 0.183 | 0.00107 | 0 | 1.16 KB |
#6020 | SendReceive |
net6.0 | 1.28μs | 0.578ns | 2.08ns | 0.016 | 0 | 0 | 1.14 KB |
#6020 | SendReceive |
netcoreapp3.1 | 1.84μs | 1.36ns | 5.27ns | 0.0156 | 0 | 0 | 1.14 KB |
#6020 | SendReceive |
net472 | 2.21μs | 1.08ns | 4.03ns | 0.183 | 0.00112 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.7μs | 1.52ns | 5.88ns | 0.0216 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.83μs | 1.55ns | 6ns | 0.0209 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.33μs | 3.68ns | 14.2ns | 0.322 | 0 | 0 | 2.04 KB |
#6020 | EnrichedLog |
net6.0 | 2.67μs | 0.694ns | 2.6ns | 0.0213 | 0 | 0 | 1.6 KB |
#6020 | EnrichedLog |
netcoreapp3.1 | 3.97μs | 2.19ns | 8.5ns | 0.0217 | 0 | 0 | 1.65 KB |
#6020 | EnrichedLog |
net472 | 4.33μs | 2.88ns | 10.8ns | 0.324 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6020
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.121
528.19
471.08
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.121 | 528.19 | 471.08 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 420ns | 0.305ns | 1.18ns | 0.00797 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 575ns | 0.509ns | 1.97ns | 0.00766 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 579ns | 0.815ns | 3.05ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 529ns | 0.967ns | 3.75ns | 0.00984 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 770ns | 0.987ns | 3.82ns | 0.00931 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 834ns | 0.786ns | 3.05ns | 0.105 | 0 | 0 | 658 B |
#6020 | StartFinishSpan |
net6.0 | 401ns | 0.318ns | 1.23ns | 0.00807 | 0 | 0 | 576 B |
#6020 | StartFinishSpan |
netcoreapp3.1 | 545ns | 0.222ns | 0.831ns | 0.00793 | 0 | 0 | 576 B |
#6020 | StartFinishSpan |
net472 | 565ns | 0.477ns | 1.85ns | 0.0917 | 0 | 0 | 578 B |
#6020 | StartFinishScope |
net6.0 | 471ns | 0.261ns | 1.01ns | 0.00983 | 0 | 0 | 696 B |
#6020 | StartFinishScope |
netcoreapp3.1 | 695ns | 0.291ns | 1.13ns | 0.00971 | 0 | 0 | 696 B |
#6020 | StartFinishScope |
net472 | 858ns | 1.01ns | 3.91ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6020
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.115
589.80
657.44
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.115 | 589.80 | 657.44 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 590ns | 0.453ns | 1.75ns | 0.00974 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 934ns | 0.69ns | 2.67ns | 0.00935 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.14μs | 0.843ns | 3.26ns | 0.104 | 0 | 0 | 658 B |
#6020 | RunOnMethodBegin |
net6.0 | 657ns | 0.6ns | 2.32ns | 0.00965 | 0 | 0 | 696 B |
#6020 | RunOnMethodBegin |
netcoreapp3.1 | 880ns | 0.669ns | 2.59ns | 0.00928 | 0 | 0 | 696 B |
#6020 | RunOnMethodBegin |
net472 | 1.1μs | 1.83ns | 7.1ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6020) (11.376M) : 0, 11376374
master (11.231M) : 0, 11231191
benchmarks/2.9.0 (11.382M) : 0, 11382231
section Automatic
This PR (6020) (7.443M) : 0, 7442962
master (7.515M) : 0, 7514608
benchmarks/2.9.0 (7.834M) : 0, 7834075
section Trace stats
master (7.733M) : 0, 7732900
section Manual
master (11.202M) : 0, 11202296
section Manual + Automatic
This PR (6020) (6.789M) : 0, 6788547
master (6.988M) : 0, 6987518
section DD_TRACE_ENABLED=0
master (10.466M) : 0, 10466013
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6020) (9.531M) : 0, 9530905
master (9.544M) : 0, 9544174
benchmarks/2.9.0 (9.745M) : 0, 9744903
section Automatic
This PR (6020) (6.585M) : 0, 6584595
master (6.633M) : 0, 6633210
section Trace stats
master (6.699M) : 0, 6699486
section Manual
master (9.456M) : 0, 9455551
section Manual + Automatic
This PR (6020) (6.162M) : 0, 6161853
master (6.210M) : 0, 6209519
section DD_TRACE_ENABLED=0
master (9.025M) : 0, 9024862
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6020) (10.166M) : 0, 10166189
master (10.276M) : 0, 10276111
benchmarks/2.9.0 (10.073M) : 0, 10073079
section Automatic
This PR (6020) (6.857M) : 0, 6857373
master (6.636M) : 0, 6635574
benchmarks/2.9.0 (7.410M) : 0, 7409502
section Trace stats
master (7.388M) : 0, 7387724
section Manual
master (9.906M) : 0, 9906408
section Manual + Automatic
This PR (6020) (6.383M) : 0, 6383450
master (6.175M) : 0, 6174678
section DD_TRACE_ENABLED=0
master (9.259M) : 0, 9258887
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary of changes
Enable SSI telemetry only by env var
Reason for change
Avoid conflicts with Tracer telemetry
Implementation details
Enable SSI telemetry only when DD_INTERNAL_PROFILING_SSI_TELEMETRY_ENABLED is set AND deployed via SSI
Test coverage
Corresponding tests have been updated and incremented to cover the new scenarios
Other details