-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #5995
Conversation
I ran this to see if it worked with the new permissions as the same permissions are failing on other repositories |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5995) - mean (70ms) : 68, 72
. : milestone, 70,
master - mean (70ms) : 67, 73
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5995) - mean (1,103ms) : 1081, 1126
. : milestone, 1103,
master - mean (1,105ms) : 1067, 1143
. : milestone, 1105,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5995) - mean (109ms) : 107, 111
. : milestone, 109,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5995) - mean (769ms) : 752, 785
. : milestone, 769,
master - mean (766ms) : 751, 782
. : milestone, 766,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5995) - mean (92ms) : 90, 95
. : milestone, 92,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5995) - mean (726ms) : 705, 747
. : milestone, 726,
master - mean (727ms) : 707, 747
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5995) - mean (191ms) : 187, 194
. : milestone, 191,
master - mean (191ms) : 187, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (5995) - mean (1,192ms) : 1174, 1210
. : milestone, 1192,
master - mean (1,202ms) : 1165, 1240
. : milestone, 1202,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5995) - mean (276ms) : 271, 282
. : milestone, 276,
master - mean (276ms) : 270, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5995) - mean (941ms) : 927, 955
. : milestone, 941,
master - mean (938ms) : 918, 958
. : milestone, 938,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5995) - mean (266ms) : 262, 269
. : milestone, 266,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5995) - mean (924ms) : 906, 941
. : milestone, 924,
master - mean (922ms) : 906, 939
. : milestone, 922,
|
Datadog ReportBranch report: ✅ 0 Failed, 368165 Passed, 2064 Skipped, 15h 32m 25.35s Total Time |
<!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.42.0 --> | ||
<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.42.0" /> | ||
<!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.43.0 --> | ||
<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.43.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untested
Benchmarks Report for tracer 🐌Benchmarks for #5995 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.134 | 1,331.72 | 1,173.84 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteNonQuery |
net6.0 | 1.33μs | 1.77ns | 6.85ns | 0.0145 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
netcoreapp3.1 | 1.77μs | 1.64ns | 6.35ns | 0.0131 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
net472 | 2.11μs | 3.79ns | 14.7ns | 0.156 | 0 | 0 | 987 B |
#5995 | ExecuteNonQuery |
net6.0 | 1.17μs | 0.75ns | 2.9ns | 0.0142 | 0 | 0 | 1.02 KB |
#5995 | ExecuteNonQuery |
netcoreapp3.1 | 1.76μs | 2.22ns | 8.61ns | 0.0133 | 0 | 0 | 1.02 KB |
#5995 | ExecuteNonQuery |
net472 | 2.08μs | 1.21ns | 4.69ns | 0.157 | 0 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.16μs | 1.43ns | 5.55ns | 0.0139 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.54μs | 1.35ns | 5.06ns | 0.0131 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.32μs | 2.44ns | 9.47ns | 0.157 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.37μs | 1.26ns | 4.87ns | 0.0133 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.61μs | 0.997ns | 3.59ns | 0.0138 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.64μs | 1.8ns | 6.99ns | 0.167 | 0 | 0 | 1.05 KB |
#5995 | CallElasticsearch |
net6.0 | 1.24μs | 0.481ns | 1.8ns | 0.0136 | 0 | 0 | 976 B |
#5995 | CallElasticsearch |
netcoreapp3.1 | 1.57μs | 0.755ns | 2.92ns | 0.0133 | 0 | 0 | 976 B |
#5995 | CallElasticsearch |
net472 | 2.43μs | 1.2ns | 4.5ns | 0.157 | 0 | 0 | 995 B |
#5995 | CallElasticsearchAsync |
net6.0 | 1.32μs | 3.21ns | 12ns | 0.0132 | 0 | 0 | 952 B |
#5995 | CallElasticsearchAsync |
netcoreapp3.1 | 1.63μs | 2.41ns | 9.32ns | 0.0138 | 0 | 0 | 1.02 KB |
#5995 | CallElasticsearchAsync |
net472 | 2.67μs | 1.51ns | 5.44ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #5995
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0
1.190
1,349.45
1,134.26
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.190 | 1,349.45 | 1,134.26 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.35μs | 1.85ns | 7.18ns | 0.0131 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.72μs | 0.535ns | 2ns | 0.0127 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.81μs | 1.38ns | 5.34ns | 0.145 | 0 | 0 | 915 B |
#5995 | ExecuteAsync |
net6.0 | 1.13μs | 0.614ns | 2.38ns | 0.0136 | 0 | 0 | 952 B |
#5995 | ExecuteAsync |
netcoreapp3.1 | 1.58μs | 0.645ns | 2.5ns | 0.0126 | 0 | 0 | 952 B |
#5995 | ExecuteAsync |
net472 | 1.85μs | 1.39ns | 5.2ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.23μs | 1.81ns | 6.76ns | 0.0295 | 0 | 0 | 2.22 KB |
master | SendAsync |
netcoreapp3.1 | 5.17μs | 2.8ns | 10.1ns | 0.0361 | 0 | 0 | 2.76 KB |
master | SendAsync |
net472 | 7.81μs | 1.46ns | 5.65ns | 0.497 | 0 | 0 | 3.15 KB |
#5995 | SendAsync |
net6.0 | 4.21μs | 1.24ns | 4.46ns | 0.0316 | 0 | 0 | 2.22 KB |
#5995 | SendAsync |
netcoreapp3.1 | 5.18μs | 1.51ns | 5.84ns | 0.0362 | 0 | 0 | 2.76 KB |
#5995 | SendAsync |
net472 | 7.73μs | 2.77ns | 10.7ns | 0.496 | 0 | 0 | 3.15 KB |
Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5995
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0
1.117
1,490.55
1,664.61
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.117 | 1,490.55 | 1,664.61 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.49μs | 0.775ns | 2.9ns | 0.023 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.33μs | 1.44ns | 5.38ns | 0.022 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.61μs | 1.33ns | 5.15ns | 0.249 | 0 | 0 | 1.57 KB |
#5995 | EnrichedLog |
net6.0 | 1.66μs | 0.716ns | 2.77ns | 0.0233 | 0 | 0 | 1.64 KB |
#5995 | EnrichedLog |
netcoreapp3.1 | 2.3μs | 1.58ns | 5.89ns | 0.0218 | 0 | 0 | 1.64 KB |
#5995 | EnrichedLog |
net472 | 2.68μs | 1.49ns | 5.76ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 117μs | 222ns | 859ns | 0.0576 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 121μs | 210ns | 815ns | 0.0602 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 151μs | 128ns | 495ns | 0.672 | 0.224 | 0 | 4.46 KB |
#5995 | EnrichedLog |
net6.0 | 119μs | 258ns | 1μs | 0.0593 | 0 | 0 | 4.28 KB |
#5995 | EnrichedLog |
netcoreapp3.1 | 122μs | 147ns | 568ns | 0.0606 | 0 | 0 | 4.28 KB |
#5995 | EnrichedLog |
net472 | 150μs | 155ns | 600ns | 0.673 | 0.224 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.9μs | 0.868ns | 3.36ns | 0.031 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.38μs | 0.999ns | 3.87ns | 0.0284 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 5.02μs | 1.26ns | 4.89ns | 0.32 | 0 | 0 | 2.02 KB |
#5995 | EnrichedLog |
net6.0 | 2.91μs | 2.3ns | 8.91ns | 0.0306 | 0 | 0 | 2.2 KB |
#5995 | EnrichedLog |
netcoreapp3.1 | 4.13μs | 1.41ns | 5.28ns | 0.0296 | 0 | 0 | 2.2 KB |
#5995 | EnrichedLog |
net472 | 4.79μs | 1.19ns | 4.59ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.38μs | 0.536ns | 2.07ns | 0.016 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.73μs | 0.849ns | 3.29ns | 0.0156 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.1μs | 1.16ns | 4.51ns | 0.183 | 0.00104 | 0 | 1.16 KB |
#5995 | SendReceive |
net6.0 | 1.41μs | 0.554ns | 2.14ns | 0.0163 | 0 | 0 | 1.14 KB |
#5995 | SendReceive |
netcoreapp3.1 | 1.83μs | 1.07ns | 4.16ns | 0.0156 | 0 | 0 | 1.14 KB |
#5995 | SendReceive |
net472 | 2.13μs | 2.27ns | 8.8ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.76μs | 0.98ns | 3.8ns | 0.0221 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.65μs | 1.38ns | 5.35ns | 0.0221 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.43μs | 1.46ns | 5.48ns | 0.323 | 0 | 0 | 2.04 KB |
#5995 | EnrichedLog |
net6.0 | 2.64μs | 0.86ns | 3.33ns | 0.0224 | 0 | 0 | 1.6 KB |
#5995 | EnrichedLog |
netcoreapp3.1 | 4μs | 3.48ns | 13.5ns | 0.0215 | 0 | 0 | 1.65 KB |
#5995 | EnrichedLog |
net472 | 4.48μs | 3.42ns | 13.3ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5995
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1
1.138
710.64
808.54
Faster 🎉 in #5995
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472
1.136
684.40
602.68
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.138 | 710.64 | 808.54 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.136 | 684.40 | 602.68 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 400ns | 0.141ns | 0.548ns | 0.00803 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 597ns | 0.312ns | 1.21ns | 0.00794 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 684ns | 0.501ns | 1.87ns | 0.0918 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 505ns | 0.216ns | 0.836ns | 0.00966 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 711ns | 0.58ns | 2.24ns | 0.0095 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 808ns | 2.52ns | 9.75ns | 0.104 | 0 | 0 | 658 B |
#5995 | StartFinishSpan |
net6.0 | 403ns | 0.158ns | 0.612ns | 0.0081 | 0 | 0 | 576 B |
#5995 | StartFinishSpan |
netcoreapp3.1 | 556ns | 0.217ns | 0.813ns | 0.00784 | 0 | 0 | 576 B |
#5995 | StartFinishSpan |
net472 | 602ns | 0.25ns | 0.967ns | 0.0917 | 0 | 0 | 578 B |
#5995 | StartFinishScope |
net6.0 | 535ns | 2.99ns | 19.2ns | 0.00984 | 0 | 0 | 696 B |
#5995 | StartFinishScope |
netcoreapp3.1 | 807ns | 0.751ns | 2.91ns | 0.00926 | 0 | 0 | 696 B |
#5995 | StartFinishScope |
net472 | 885ns | 0.463ns | 1.79ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #5995
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1
1.120
1,020.27
910.75
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.120 | 1,020.27 | 910.75 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 656ns | 1.06ns | 3.83ns | 0.00984 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 1.02μs | 0.923ns | 3.57ns | 0.00926 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.1μs | 1.57ns | 6.07ns | 0.104 | 0 | 0 | 658 B |
#5995 | RunOnMethodBegin |
net6.0 | 675ns | 0.151ns | 0.564ns | 0.0098 | 0 | 0 | 696 B |
#5995 | RunOnMethodBegin |
netcoreapp3.1 | 911ns | 0.331ns | 1.24ns | 0.00966 | 0 | 0 | 696 B |
#5995 | RunOnMethodBegin |
net472 | 1.12μs | 0.38ns | 1.47ns | 0.105 | 0 | 0 | 658 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test out Cosmo locally and if it isn't working I'll get something scheduled to fix it
0d4acca
to
f12ccac
Compare
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5995) (10.867M) : 0, 10867106
master (11.098M) : 0, 11098480
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (5995) (7.252M) : 0, 7252323
master (7.197M) : 0, 7196894
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.633M) : 0, 7632576
section Manual
master (11.005M) : 0, 11005247
section Manual + Automatic
This PR (5995) (6.783M) : 0, 6782613
master (6.782M) : 0, 6781842
section DD_TRACE_ENABLED=0
master (10.205M) : 0, 10205469
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5995) (9.428M) : 0, 9428337
master (9.594M) : 0, 9594252
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (5995) (6.525M) : 0, 6524757
master (6.687M) : 0, 6686910
section Trace stats
master (6.937M) : 0, 6937224
section Manual
master (9.495M) : 0, 9495445
section Manual + Automatic
This PR (5995) (5.918M) : 0, 5917708
master (6.109M) : 0, 6108826
section DD_TRACE_ENABLED=0
master (8.886M) : 0, 8886342
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5995) (9.974M) : 0, 9974455
master (10.010M) : 0, 10009662
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (5995) (6.577M) : 0, 6576656
master (6.610M) : 0, 6610335
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.259M) : 0, 7258665
section Manual
master (10.026M) : 0, 10025796
section Manual + Automatic
This PR (5995) (6.092M) : 0, 6092124
master (6.249M) : 0, 6248937
section DD_TRACE_ENABLED=0
master (9.319M) : 0, 9319267
|
f12ccac
to
743d220
Compare
8c39986
to
6f04d7f
Compare
@@ -13,33 +13,33 @@ | |||
|
|||
<!-- Integration: Amazon.Lambda.RuntimeSupport --> | |||
<!-- Assembly: Amazon.Lambda.RuntimeSupport --> | |||
<!-- Latest package https://www.nuget.org/packages/Amazon.Lambda.RuntimeSupport/1.10.0 --> | |||
<!-- Latest package https://www.nuget.org/packages/Amazon.Lambda.RuntimeSupport/1.11.0 --> | |||
<PackageReference Include="Amazon.Lambda.RuntimeSupport" Version="1.10.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this didn't update 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, because we were specifically running against 1.10.*
. I think that's a mistake, so updated the json to 1.*.*
and re-ran using .\tracer\build.ps1 GeneratePackageVersions --skip --include-packages Amazon.Lambda.RuntimeSupport
<!-- Latest package https://www.nuget.org/packages/log4net/2.0.17 --> | ||
<!-- Latest package https://www.nuget.org/packages/log4net/3.0.0 --> | ||
<PackageReference Include="log4net" Version="2.0.17" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add support here for a new major version: @bouwkast @lucaspimentel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I'll get a PR going for it
<!-- Latest package https://www.nuget.org/packages/GraphQL/8.0.2 --> | ||
<!-- Latest package https://www.nuget.org/packages/GraphQL/8.1.0 --> | ||
<PackageReference Include="GraphQL" Version="7.9.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add support here for a new major version: @bouwkast @lucaspimentel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I'll get a PR going for it
<!-- Latest package https://www.nuget.org/packages/MSTest.TestAdapter/3.5.2 --> | ||
<PackageReference Include="MSTest.TestAdapter" Version="3.5.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluded it from this PR for you to look into separately
4415dad
to
441d6e3
Compare
441d6e3
to
f694ba4
Compare
Updates the package versions for integration tests.