-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2.x smoke test and installer tests #5994
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 346729 Passed, 1763 Skipped, 14h 1m 24.27s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5994) - mean (74ms) : 64, 83
. : milestone, 74,
master - mean (70ms) : 66, 74
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5994) - mean (1,040ms) : 1018, 1063
. : milestone, 1040,
master - mean (1,084ms) : 1061, 1107
. : milestone, 1084,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5994) - mean (110ms) : 105, 115
. : milestone, 110,
master - mean (109ms) : 105, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5994) - mean (727ms) : 700, 755
. : milestone, 727,
master - mean (763ms) : 740, 786
. : milestone, 763,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5994) - mean (93ms) : 89, 97
. : milestone, 93,
master - mean (93ms) : 89, 97
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5994) - mean (682ms) : 664, 701
. : milestone, 682,
master - mean (714ms) : 694, 733
. : milestone, 714,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5994) - mean (191ms) : 187, 194
. : milestone, 191,
master - mean (191ms) : 188, 195
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (5994) - mean (1,118ms) : 1098, 1138
. : milestone, 1118,
master - mean (1,165ms) : 1136, 1193
. : milestone, 1165,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5994) - mean (275ms) : 271, 280
. : milestone, 275,
master - mean (275ms) : 271, 279
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (5994) - mean (885ms) : 859, 912
. : milestone, 885,
master - mean (923ms) : 898, 948
. : milestone, 923,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5994) - mean (265ms) : 261, 269
. : milestone, 265,
master - mean (265ms) : 260, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5994) - mean (869ms) : 841, 897
. : milestone, 869,
master - mean (906ms) : 884, 929
. : milestone, 906,
|
Benchmarks Report for tracer 🐌Benchmarks for #5994 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.191 | 400.04 | 476.64 | |
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.151 | 622.39 | 716.60 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 400ns | 0.142ns | 0.532ns | 0.00805 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 588ns | 0.562ns | 2.18ns | 0.00787 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 623ns | 1.11ns | 4.31ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 497ns | 0.419ns | 1.62ns | 0.00967 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 731ns | 1.96ns | 7.61ns | 0.00952 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 884ns | 0.993ns | 3.84ns | 0.104 | 0 | 0 | 658 B |
#5994 | StartFinishSpan |
net6.0 | 476ns | 0.174ns | 0.672ns | 0.00815 | 0 | 0 | 576 B |
#5994 | StartFinishSpan |
netcoreapp3.1 | 602ns | 0.256ns | 0.992ns | 0.00799 | 0 | 0 | 576 B |
#5994 | StartFinishSpan |
net472 | 715ns | 1.79ns | 6.92ns | 0.0916 | 0 | 0 | 578 B |
#5994 | StartFinishScope |
net6.0 | 490ns | 0.212ns | 0.823ns | 0.00987 | 0 | 0 | 696 B |
#5994 | StartFinishScope |
netcoreapp3.1 | 743ns | 0.76ns | 2.94ns | 0.00929 | 0 | 0 | 696 B |
#5994 | StartFinishScope |
net472 | 849ns | 1.23ns | 4.77ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #5994
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.133
748.23
660.22
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1
1.126
998.86
887.05
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.133 | 748.23 | 660.22 | |
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.126 | 998.86 | 887.05 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 748ns | 0.702ns | 2.72ns | 0.00971 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 1E+03ns | 1.28ns | 4.97ns | 0.00912 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.11μs | 1.33ns | 5.14ns | 0.104 | 0 | 0 | 658 B |
#5994 | RunOnMethodBegin |
net6.0 | 660ns | 0.593ns | 2.3ns | 0.00982 | 0 | 0 | 696 B |
#5994 | RunOnMethodBegin |
netcoreapp3.1 | 887ns | 0.32ns | 1.15ns | 0.00927 | 0 | 0 | 696 B |
#5994 | RunOnMethodBegin |
net472 | 1.08μs | 0.587ns | 2.2ns | 0.104 | 0 | 0 | 658 B |
116c3b4
to
e97676d
Compare
e97676d
to
bc31e5a
Compare
e7e2c65
to
c89b949
Compare
- Fix nuget/dd-trace installer tests for the future The code we were using to install the "local" builds of the NuGet packages added the local source. However the dotnet restore was looking in both the local and nuget.org sources, and installing the highest version it found. That worked fine until we released 3.2.0 publicly and expect to install 2.59.0 of the local build. Install an explicit version of the tracer. As this version is never in the public nuget.org source but _is_ in the local source, it uses that. Having to thread the version through everywhere is kinda horrible, but is the only thing I could find that works. The whole approach should be rewritten to be managed by Nuke tbh, if we ever find time
## Summary of changes - Fix nuget/dd-trace installer tests in 2.x branch ## Reason for change The code we were using to install the "local" builds of the NuGet packages added the local source. However the dotnet restore was looking in both the local and nuget.org sources, and installing the highest version it found. That worked fine until we released 3.2.0 publicly and expect to install 2.59.0 of the local build. ## Implementation details Install an explicit version of the tracer. As this version is never in the public nuget.org source but _is_ in the local source, it uses that. > In #5989 I tried a different approach but it just didn't work. Having to thread the version through everywhere is kinda horrible, but is the only thing I could find that works. ## Test coverage Will run a [full installer test](https://dev.azure.com/datadoghq/dd-trace-dotnet/_build/results?buildId=163706&view=results) ## Other details The whole approach should be rewritten to be managed by Nuke tbh, if we ever find time This PR is a "forward port" of - #5994 (the issue was exhibited on the 2.x branch, so this is preemptive for the future)
Summary of changes
Reason for change
The code we were using to install the "local" builds of the NuGet packages added the local source. However the dotnet restore was looking in both the local and nuget.org sources, and installing the highest version it found. That worked fine until we released 3.2.0 publicly and expect to install 2.59.0 of the local build.
For system-tests, we had to change how things work to support v3 (DataDog/system-tests#2962), but unfortunately that breaks for v2.
Implementation details
Install an explicit version of the tracer. As this version is never in the public nuget.org source but is in the local source, it uses that.
For system tests, just pinning to the specific commit prior to the v3 PR being merged.
Having to thread the version through everywhere is kinda horrible, but is the only thing I could find that works.
Test coverage
Running a full installer run here
Other details
The whole approach should be rewritten to be managed by Nuke tbh, if we ever find time
This PR also contains a backport of
for simplicity
Supersedes