Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIVIS-9555] Network Instrumentation crashes test process #94

Merged
merged 5 commits into from
Apr 8, 2024
Merged

[CIVIS-9555] Network Instrumentation crashes test process #94

merged 5 commits into from
Apr 8, 2024

Conversation

ypopovych
Copy link
Contributor

@ypopovych ypopovych commented Apr 5, 2024 •
edited
Loading

What and why?

Fixed crash caused by network instrumentation.

Fixes: #84

How?

  • Switched to the OpenTelemetry v1.9.2
  • Updated XCTestObserver to properly handle transitional suites
  • Added environment key to disable Mach crash handler (it has conflicts with debugger).

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ypopovych ypopovych requested a review from a team as a code owner April 5, 2024 12:12
@ypopovych ypopovych merged commit 85606c3 into main Apr 8, 2024
1 check passed
@ypopovych ypopovych deleted the yehor-popovych/fix-network-crash branch April 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing SDK crashes while running tests in parallel
2 participants
@ypopovych @juan-fernandez