[CIVIS-6856] Cleaned project. Updated to the latest libs and Xcode. Fixed tests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyredondo
reviewed
Mar 7, 2024
|
do these changes look good now @tonyredondo ? Is the PR ready to be merged @ypopovych ? |
Yes. This one can be merged. |
tonyredondo
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Updated project for Xcode 15.
Fixed CI environment parsing
How?
Updated project minimum os versions and script security settings.
Cleaned project - removed non-needed scripts and settings.
Updated Makefile. Moved upload binary script logic inside Makefile
Fixed environment parsing without changing implementation
Review checklist