changes for use by new nginx module #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o static-nginx-module
|
THanks
…On Wed, Apr 6, 2022 at 5:23 PM Caleb Gilmour ***@***.***> wrote:
***@***.**** approved this pull request.
Rubber-stamp!
—
Reply to this email directly, view it on GitHub
<#221 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHW255DKSPQJQGPFJDHMSLVDX6FPANCNFSM5SCJBT3A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dgoffredo
force-pushed
the
david.goffredo/changes-for-nginx-module
branch
from
118c604 to
0591a21
Compare
|
Wow the in-browser merge conflict editor really screwed this up. |
dgoffredo
added a commit
that referenced
this pull request
Apr 7, 2022
|
Closing this in favor of #224. |
dgoffredo
added a commit
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a new build target,
dd_opentracing-object, that the new nginx module can use to get the compilation commands from this project without having to build an intermediate archive.I also factor out the JSON serialization of
TracerOptions, and remove zlib as a build dependency (it's not needed).The new nginx module (still in development) will use the factored-out function to allow nginx to print the tracer configuration on demand, which is used in testing.