remove injection of X-Datadog-Tags #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrelating that information across services
cgilmour
approved these changes
Feb 28, 2022
cgilmour
approved these changes
Mar 2, 2022
|
Oh yeah, forgot that. Will do. |
dgoffredo
added a commit
that referenced
this pull request
Jun 30, 2022
dgoffredo
added a commit
that referenced
this pull request
Jul 1, 2022
* remove all remnants of UpstreamService * undo non-test related removals from #218 * fix bug * add additional "sample" test * add "span" tests * clang-format * allow configuration of trace_tags_propagation_max_length in dynamic load JSON * add "decision maker" tag to nginx integration tests * document DD_TRACE_TAGS_PROPAGATION_MAX_LENGTH * clang-format (again) * no UpstreamService talk * remove base64 (was used only by UpstreamService) * max_size -> inject_max_size * trace_tags_propagation_max_length -> tags_header_size
dgoffredo
added a commit
that referenced
this pull request
Jul 1, 2022
dgoffredo
added a commit
that referenced
this pull request
Jul 1, 2022
dgoffredo
added a commit
that referenced
this pull request
Jul 5, 2022
dgoffredo
added a commit
that referenced
this pull request
Jul 15, 2022
* undo non-test related removals from #218 * fix bug * add additional "sample" test * clang-format * glob.{h,cpp} * class SpanSampler, without using or testing it * small (premature?) optimization * TODO: AMEND * checkpoint: added span rules to Tracer, but not elsewhere * checkpoint: add span rules to SpanBuffer, but don't use them * checkpoint: written but untested * test rule parsing * obnoxious compiler * test rule matching * test span sampling * clang-format * test environment variables * repo-level documentation * attempt at fixing doc links * describe glob in the repo-level docs * unit tests catch bugs! * a little const correctness * code comment typo * temporary files are temporary * review: trim some docs and add an example * review: describe globs more concretely * review: make a future diff smaller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're considering other ways of correlating that information across services. For now let's remove this feature.