Change URL obfuscation behavior #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes an option to keep using existing obfuscation behavior by setting the environment variable `DD_TRACE_CPP_LEGACY_OBFUSCATION=1`.
bengl
approved these changes
Jul 9, 2020
cgilmour
force-pushed
the
cgilmour/tag-fixes
branch
from
a0e6829 to
7bf834f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http.urltag gets obfuscated too heavily, to the point where it's not very useful. It was also inconsistent with other tracers.This PR makes it consistent with other tracers, but has an option to keep using the "legacy obfuscation" by setting an environment variable:
DD_TRACE_CPP_LEGACY_OBFUSCATION=1Fine-grained control of replacements can be configured on the agent using tag filtering