-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pup #78
Conversation
We'll hold off on this until it's 100% ready to roll. And we'll include pup itself then as well. |
@revivek are there any tests for the new end point? |
@alq666 I've only sent well formed data to the new endpoint. It would be beneficial to test malformed data. I'll hold off on it though for the reason @clutchski mentioned. |
@revivek still current or should be closed? |
If we felt that the installation on Friday worked, then yes! It's still current and isn't merged in yet. |
@xcolour when you have the time to take a pass at it. Not as important as AWS issues. |
Don't send data to Datadog for non-Datadog users. We would ignore them anyway.
Merged into master. |
Hey, This contains a couple of broken commits. I fixed the code on the branch "merge-pup" yesterday and merged it to master. This should be reverted. I'll take a look at it tomorrow. Matt |
@clutchski Note that we can't quite deliver pup as a package as it is, mostly because we have not moved the assets (js, html) in the proper directory. We can ship 3.0.5 without pup as it contains a few much-needed bugfixes. |
**Changes** * [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [#81][] * [FEATURE] Support `float` and `java.lang.Float` attribute types as * simple JMX attributes. See [#76][] * [FEATURE] Support Cassandra > 2.2 metric name structure * (CASSANDRA-4009). See [#79][] * [FEATURE] Support custom JMX Service URL to connect to, on a * per-instance basis. See [#80][] * [IMPROVEMENT] Assign generic alias if not defined. See [#78][] <!--- The following link definition list is generated by PimpMyChangelog ---> [#76]: DataDog/jmxfetch#76 [#78]: DataDog/jmxfetch#78 [#79]: DataDog/jmxfetch#79 [#80]: DataDog/jmxfetch#80 [#81]: DataDog/jmxfetch#81
**Changes** * [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [DataDog#81][] * [FEATURE] Support `float` and `java.lang.Float` attribute types as * simple JMX attributes. See [DataDog#76][] * [FEATURE] Support Cassandra > 2.2 metric name structure * (CASSANDRA-4009). See [DataDog#79][] * [FEATURE] Support custom JMX Service URL to connect to, on a * per-instance basis. See [DataDog#80][] * [IMPROVEMENT] Assign generic alias if not defined. See [DataDog#78][] <!--- The following link definition list is generated by PimpMyChangelog ---> [DataDog#76]: DataDog/jmxfetch#76 [DataDog#78]: DataDog/jmxfetch#78 [DataDog#79]: DataDog/jmxfetch#79 [DataDog#80]: DataDog/jmxfetch#80 [DataDog#81]: DataDog/jmxfetch#81
Added pup configuration. Exits if no endpoints are chosen.