Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pup #78

Closed
wants to merge 11 commits into from
Closed

Add pup #78

wants to merge 11 commits into from

Conversation

revivek
Copy link
Contributor

@revivek revivek commented Jun 14, 2012

Added pup configuration. Exits if no endpoints are chosen.

@clutchski
Copy link
Contributor

We'll hold off on this until it's 100% ready to roll. And we'll include pup itself then as well.

@alq666
Copy link
Member

alq666 commented Jun 14, 2012

@revivek are there any tests for the new end point?

@revivek
Copy link
Contributor Author

revivek commented Jun 15, 2012

@alq666 I've only sent well formed data to the new endpoint. It would be beneficial to test malformed data. I'll hold off on it though for the reason @clutchski mentioned.

@alq666
Copy link
Member

alq666 commented Aug 1, 2012

@revivek still current or should be closed?

@revivek
Copy link
Contributor Author

revivek commented Aug 1, 2012

If we felt that the installation on Friday worked, then yes! It's still current and isn't merged in yet.

@ghost ghost assigned xcolour Aug 1, 2012
@alq666
Copy link
Member

alq666 commented Aug 1, 2012

@xcolour when you have the time to take a pass at it. Not as important as AWS issues.

@ghost ghost assigned clutchski Aug 9, 2012
@alq666 alq666 closed this Aug 10, 2012
@alq666
Copy link
Member

alq666 commented Aug 10, 2012

Merged into master.

@clutchski
Copy link
Contributor

Hey,

This contains a couple of broken commits. I fixed the code on the branch "merge-pup" yesterday and merged it to master. This should be reverted. I'll take a look at it tomorrow.

Matt

@alq666
Copy link
Member

alq666 commented Aug 13, 2012

@clutchski Note that we can't quite deliver pup as a package as it is, mostly because we have not moved the assets (js, html) in the proper directory. We can ship 3.0.5 without pup as it contains a few much-needed bugfixes.

yannmh added a commit that referenced this pull request Nov 3, 2015
**Changes**
* [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [#81][]
* [FEATURE] Support `float` and `java.lang.Float` attribute types as
* simple JMX attributes. See [#76][]
* [FEATURE] Support Cassandra > 2.2 metric name structure
* (CASSANDRA-4009). See [#79][]
* [FEATURE] Support custom JMX Service URL to connect to, on a
* per-instance basis. See [#80][]
* [IMPROVEMENT] Assign generic alias if not defined. See [#78][]

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#76]: DataDog/jmxfetch#76
[#78]: DataDog/jmxfetch#78
[#79]: DataDog/jmxfetch#79
[#80]: DataDog/jmxfetch#80
[#81]: DataDog/jmxfetch#81
urosgruber pushed a commit to urosgruber/dd-agent that referenced this pull request Dec 23, 2015
**Changes**
* [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [DataDog#81][]
* [FEATURE] Support `float` and `java.lang.Float` attribute types as
* simple JMX attributes. See [DataDog#76][]
* [FEATURE] Support Cassandra > 2.2 metric name structure
* (CASSANDRA-4009). See [DataDog#79][]
* [FEATURE] Support custom JMX Service URL to connect to, on a
* per-instance basis. See [DataDog#80][]
* [IMPROVEMENT] Assign generic alias if not defined. See [DataDog#78][]

<!--- The following link definition list is generated by PimpMyChangelog
--->
[DataDog#76]: DataDog/jmxfetch#76
[DataDog#78]: DataDog/jmxfetch#78
[DataDog#79]: DataDog/jmxfetch#79
[DataDog#80]: DataDog/jmxfetch#80
[DataDog#81]: DataDog/jmxfetch#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants