Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jmx_custom_jars option to datadog.yaml #3648

Merged
merged 2 commits into from
Jan 31, 2018
Merged

add jmx_custom_jars option to datadog.yaml #3648

merged 2 commits into from
Jan 31, 2018

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Jan 29, 2018 •
edited
Loading

This enables users to load a custom jar at jmxfetch start,
to allow using them reliably in AD templates

Only supporting a single string in agent5 to enable the use of
the DD_CONF_JMX_CUSTOM_JARS envvar binding, agent6 will support
a string array

datadog/dev-dd-agent:backport_3648 allows to test it

@xvello
add jmx_custom_jar option to datadog.yaml
dcd96b4 
This enables users to load a custom jar at jmxfetch start,
to allow using them reliably in AD templates

Only supporting a single string in agent5 to enable the use of
the DD_CONF_JMX_CUSTOM_JAR envvar binding, agent6 will support
a string array
@xvello xvello added this to the 5.22.0 milestone Jan 29, 2018
@xvello xvello requested a review from truthbk January 29, 2018 11:19
truthbk
truthbk approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you want to add support for environment variables? If so, maybe this is a good time to add that?

@xvello
Copy link
Contributor Author

xvello commented Jan 31, 2018

The DD_CONF_* envvars are automatically added to datadog.conf, so we don't need to create a dedicated envvar binding in the entrypoint. The agent6 one will be called DD_JMX_CUSTOM_JAR though, as the convention changed.

truthbk
truthbk approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@xvello xvello changed the title add jmx_custom_jar option to datadog.yaml add jmx_custom_jars option to datadog.yaml Jan 31, 2018
@xvello xvello merged commit 43b70b4 into master Jan 31, 2018
@xvello xvello deleted the xvello/jmxfetch-custom-jar branch January 31, 2018 13:41
@xvello xvello mentioned this pull request Jan 31, 2018
Merged
wolf31o2 added a commit to wolf31o2/datadog_cookbook that referenced this pull request Mar 18, 2019
@wolf31o2
Support jmx_custom_jars datadog.conf option
6e209d1 
As remediation for DataDog support ticket #209172, I was pointed at
DataDog/dd-agent/pull/3648 to set `jmx_custom_jars` in `datadog.conf`,
which is not supported by the current template. Patch the template to
support this option.

Signed-off-by: Chris Gianelloni <[email protected]>
@wolf31o2 wolf31o2 mentioned this pull request Mar 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
service discovery
Projects
None yet
Milestone
5.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xvello @truthbk