Add early-exit to TracingChannel #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
tracing-channel-early-exit
branch
from
58a0b61
to
3556072
Compare
8 tasks
|
Ah...I seem to have run into some bugs with the existing code. The |
tlhunter
force-pushed
the
tracing-channel-early-exit
branch
from
3556072
to
cfd0362
Compare
tlhunter
added a commit
that referenced
this pull request
May 9, 2024
- some `diagnostics_channel` changes landed in Node.js in nodejs/node#51915 - this PR adds the `TracingChannel#hasSubscribers` helper method available in Node.js v22 and v20.13 - this PR _does not_ add the early exit functionality from that same commit - since this PR only implements half of the functionality in that commit we aren't fully v22 and v20.13 compatible - for that reason I haven't updated the README to state that we track said versions - I did add a note to the README about this partial jump in functionality - this PR also adds CI tests against Node.js v22.x - partially obsoletes #10 which is a WIP that attempted to implement both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 21.8.0 will add support for TracingChannel trace methods exiting early. I opted for just editing the exiting TracingChannel polyfill to fully replace the core TracingChannel up to 21.8.0 as the change required edits to every method anyway. Fully replacing it has better performance than adding a wrapping execution later unnecessarily.