This repository has been archived by the owner on Aug 30, 2019. It is now read-only.
config: enable to set "MaxTPS" from environment variable #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed, but I'm not sure if it's related this pull request: |
gbbr
changed the title
gbbr
reviewed
Nov 7, 2018
|
P.S. Don't worry about CI, it's a separate issue that we are having with the |
|
Thank you for the quick review and feedback! And I understood about the CI. Thanks! |
gbbr
approved these changes
Nov 7, 2018
|
Thank you! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this pull request because the same motivation as DataDog/docker-dd-agent#291 .
We are heavy users of APM and require a higher max_traces_per_second than what the default provides (10).
I know we can specify the value in datadog.yaml (tracer.sampler > max_traces_per_second), but it would be great if we can use an environment variable for it. Especially under container environment like Kubernetes, it's really useful and convenient.