Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Support mac/darwin #31

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Support mac/darwin #31

merged 1 commit into from
Aug 2, 2017

Conversation

conorbranagan
Copy link
Contributor

@conorbranagan conorbranagan commented Aug 2, 2017 •
edited
Loading

Much of the work is in DataDog/gopsutil#10

On the Agent side we:

  • Made the Docker check not error/warn on mac, it's just silently skipped. Getting Docker working on mac (with stats, at least) is a whole can of worms for later on.
  • Added some additional checks for cases where Mac isn't supported yet (e.g. IOStats, Net stats)

Now it builds and runs!

@conorbranagan conorbranagan force-pushed the conor/mac branch 2 times, most recently from 23917ae to 3b7c71d Compare August 2, 2017 02:43
conorbranagan
conorbranagan commented Aug 2, 2017
View reviewed changes
checks/process.go
@@ -163,12 +163,16 @@ func formatCommand(fp *process.FilledProcess) *model.Command {
Root: "", // TODO
OnDisk: false, // TODO
Ppid: fp.Ppid,
Pgroup: fp.Pgrp,
Copy link
Contributor Author

@conorbranagan conorbranagan Aug 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing pgroup because (a) we don't make it visible anywhere in the app (and don't plan to), (b) it's not available on mac.

@conorbranagan conorbranagan merged commit e2850f8 into master Aug 2, 2017
@conorbranagan conorbranagan deleted the conor/mac branch August 2, 2017 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shang-wang shang-wang shang-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorbranagan @shang-wang