This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Remove INI config parsing/handling #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfluor
reviewed
Mar 26, 2019
sfluor
reviewed
Mar 26, 2019
sfluor
reviewed
Mar 26, 2019
| @@ -161,7 +161,7 @@ func (a *AgentConfig) loadProcessYamlConfig(path string) error { | |||
|
|
|||
| // The maximum number of processes, or containers per message. Note: Only change if the defaults are causing issues. | |||
| if maxPerMessage := config.Datadog.GetInt(key(ns, "max_per_message")); maxPerMessage > 0 { | |||
| if maxPerMessage <= maxPerMessage { | |||
| if maxPerMessage <= maxMessageBatch { | |||
sfluor
approved these changes
Mar 26, 2019
This was referenced Nov 1, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not building new agent 5 versions past 5.32.0, so instead of putting effort to move INI config handling via #264, we can just delete it and simplify our code base.