Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default liveness and readiness probes #949

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

celenechang
Copy link
Contributor

What does this PR do?

  • Remove the default liveness and readiness probes from all agent containers besides the core agent
  • Add a different default probe (same for liveness and readiness) for the trace agent container

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added the bug Something isn't working label Oct 13, 2023
@celenechang celenechang added this to the 1.2.1 milestone Oct 13, 2023
@celenechang celenechang requested review from a team as code owners October 13, 2023 15:14
@codecov-commenter
Copy link

Codecov Report

Merging #949 (883c6fd) into main (8983ac2) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   56.86%   56.81%   -0.05%     
==========================================
  Files         155      155              
  Lines       19296    19290       -6     
==========================================
- Hits        10972    10960      -12     
- Misses       7675     7681       +6     
  Partials      649      649              
Flag Coverage Δ
unittests 56.81% <4.76%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/datadoghq/v1alpha1/datadogagent_default.go 78.25% <100.00%> (-0.29%) ⬇️
...ontrollers/datadogagent/component/agent/default.go 0.00% <0.00%> (ø)
apis/datadoghq/common/common.go 19.23% <0.00%> (-5.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8983ac2...883c6fd. Read the comment docs.

@celenechang celenechang merged commit 96e2edd into main Oct 13, 2023
19 checks passed
@celenechang celenechang deleted the celene/liveness_probe branch October 13, 2023 17:50
fanny-jiang pushed a commit that referenced this pull request Oct 16, 2023
* update default liveness and readiness probes

* rm readiness probe from trace agent
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* update default liveness and readiness probes

* rm readiness probe from trace agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants