[backport] Add NodeLabelsAsTags and NamespaceLabelsAsTags, remove default Pod behavior #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v vars (#471) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <[email protected]>
JacksonDavenport
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
celenechang
approved these changes
Apr 28, 2022
Merged
celenechang
added a commit
that referenced
this pull request
May 18, 2022
…v vars (#471) (#475) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <[email protected]> Co-authored-by: Celene Chang <[email protected]>
khewonc
added a commit
that referenced
this pull request
May 19, 2022
* release v0.8.0-rc.1 * [defaulting/images] Update agent to 7.35.0 (#465) * [controllers/datadogagent/utils] Fix process collection nil check (#466) * [examples] Fix datadog-agent-secret-backend (#467) * Add port names to agent service (#468) * Update default DCA image to 1.19.0 (#470) * release v0.8.0-rc.2 * fix: k8s version detection for agent service (#472) (#473) * Add NodeLabelsAsTags and NamespaceLabelsAsTags, remove default Pod env vars (#471) (#475) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <[email protected]> Co-authored-by: Celene Chang <[email protected]> * release v0.8.0-rc.3 * Default Agent version to 7.35.2 (#480) * release v0.8.0-rc.4 * release v0.8.0 Co-authored-by: David Ortiz <[email protected]> Co-authored-by: Cedric Lamoriniere <[email protected]> Co-authored-by: JacksonDavenport <[email protected]> Co-authored-by: Celene Chang <[email protected]> Co-authored-by: Paul Cacheux <[email protected]>
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* release v0.8.0-rc.1 * [defaulting/images] Update agent to 7.35.0 (#465) * [controllers/datadogagent/utils] Fix process collection nil check (#466) * [examples] Fix datadog-agent-secret-backend (#467) * Add port names to agent service (#468) * Update default DCA image to 1.19.0 (#470) * release v0.8.0-rc.2 * fix: k8s version detection for agent service (#472) (#473) * Add NodeLabelsAsTags and NamespaceLabelsAsTags, remove default Pod env vars (#471) (#475) Remove POD_X_AS_TAGS as no longer defaulting to {} Test cases for various metadata as tags configs Move the xyzAsTags to the common set of environment variables Revert "Move the xyzAsTags to the common set of environment variables" This reverts commit 11a8cfa. Update tests to use NodeAgentConfig/EnvVar rather than generics Add port names to agent service (#468) Update default DCA image to 1.19.0 (#470) Share common structs in common/v1 and adds missing fields to v2alpha1 (#438) fix: k8s version detection for agent service (#472) Rename Test_getEnvVarsForMetadataAsTags function Co-authored-by: Celene Chang <[email protected]> Co-authored-by: Celene Chang <[email protected]> * release v0.8.0-rc.3 * Default Agent version to 7.35.2 (#480) * release v0.8.0-rc.4 * release v0.8.0 Co-authored-by: David Ortiz <[email protected]> Co-authored-by: Cedric Lamoriniere <[email protected]> Co-authored-by: JacksonDavenport <[email protected]> Co-authored-by: Celene Chang <[email protected]> Co-authored-by: Paul Cacheux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport #471 to v0.8 Branch
Add
agent.config.namespaceLabelsAsTagsandagent.config.nodeLabelsAsTagsto Operator configuration. Remove the behavior where the environment variablesDD_KUBERNETES_POD_LABELS_AS_TAGSandDD_KUBERNETES_POD_ANNOTATIONS_AS_TAGSwould default to{}when Operator config not set (instead just don't set these in the first place).Motivation
Add feature to v0.8 release
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.