-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rbac to support secret backend multiple providers script #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling
Codecov Report
@@ Coverage Diff @@
## main #459 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 3 3
Lines 132 132
=======================================
Hits 80 80
Misses 40 40
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
credentials: | ||
apiKey: ENC[k8s_secret@default/test-secret/api_key] | ||
appKey: ENC[k8s_secret@default/test-secret/app_key] | ||
useSecretBackend: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of documenting how to add an envvar.
should we add an option in the credentials
section to select which secret backend script they want to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of saving this for v2, i.e. creating a SecretBackend section (and removing credentials.useSecretBackend
). I could add on to the existing credentials
section for now if you think it's worth doing?
Co-authored-by: Ursula Chen <[email protected]>
* update rbac to support secret backend multiple providers script Co-authored-by: Ursula Chen <[email protected]>
What does this PR do?
To support use of the secret backend multiple providers script in the agent when deployed with the Datadog Operator.
Motivation
Feature parity
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
test-secret
(in the example below, it is in thesystem
namespace)