Fix DatadogAgent secret backend usage #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celenechang
added
bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
working on tests |
celenechang
force-pushed
the
celene/secretbackend_fix
branch
from
99ed7b0 to
79320f5
Compare
Codecov Report
@@ Coverage Diff @@
## main #454 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 3 3
Lines 132 132
=======================================
Hits 80 80
Misses 40 40
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Comment on lines
+193
to
+196
| - name: DD_SECRET_BACKEND_COMMAND | ||
| value: "/readsecret.sh" | ||
| - name: DD_SECRET_BACKEND_ARGUMENTS | ||
| value: "/etc/secret-volume" |
There was a problem hiding this comment.
For v2.DatadogAgent we could imaging to have specific fields for configuring the secret-backend
There was a problem hiding this comment.
i have a list of a couple changes to make for v2 regarding this feature, will add this too
Merged
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* secret backend fixes and test updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The secret backend feature for DatadogAgent was not working properly. This fixes the feature so that any credentials can use it. In addition, the Operator no longer creates a secret if it's not needed (i.e. it will not create an empty secret).
Other changes:
Motivation
Fix
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Use the new
datadog-agent-secret-backend.yamlexample file to test the secret backend feature.For completeness, can test the following cases (make sure the keys are read properly and the Agent can connect to the Cluster Agent):
(Create a secret containing credentials with
kubectl create secret generic test-secret --from-literal=api_key='<token>' --from-literal=app_key='<token>' --from-literal=token='<token>')