-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a service with local internal traffic policy for traces and dogstatsd. #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 from docs team
9949708
to
aba7f81
Compare
aba7f81
to
2aebdd0
Compare
38fefbe
to
2c77b21
Compare
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 61.05% 61.05%
=======================================
Files 3 3
Lines 95 95
=======================================
Hits 58 58
Misses 25 25
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO what is missing is a way in the DatadogAgent CR to force the creation of the service if a customer has enabled it on k8s cluster 1.21
Also maybe it will require to update the Network policy to allow the traffic on this service? |
for traces and dogstatsd.
2c77b21
to
67f8570
Compare
I’ve just updated the PR to implement here the equivalent of DataDog/helm-charts#434 which includes a way to force the service creation.
I don’t think so because Network Policies apply to pods. Reaching a pod directly or through a Service doesn’t make any difference for the Network policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
Add a service which leverages internal traffic policy for traces and dogstatsd.
Motivation
Ease the use of dogstatsd and APM as an application could use a kubernetes service instead of having to rely on the downward API to target the local node agent.
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Deploy the agent with the operator on kubernetes 1.22+ cluster and check that a new service targeting the nodes agent with local internal traffic policy has been created.