Pull v0.7 to main #373
Merged
Pull v0.7 to main #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Celene Chang <[email protected]>
* [DCA] [orchestrator] add pv and pvc rbac * Add kubebuilder comment for PV and PVC Co-authored-by: cedric lamoriniere <[email protected]>
* default `agent` image is now `7.31.0` * default `cluster-agent` image is now `1.15.0`
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
===========================================
+ Coverage 39.15% 65.10% +25.94%
===========================================
Files 65 63 -2
Lines 11465 6926 -4539
===========================================
+ Hits 4489 4509 +20
+ Misses 6657 2098 -4559
Partials 319 319
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kayayarai
approved these changes
Sep 13, 2021
CharlyF
reviewed
Sep 13, 2021
| @@ -410,7 +410,7 @@ type LogCollectionConfig struct { | |||
| // Defaults to `/var/log/containers` | |||
| // | |||
| // +optional | |||
| ContainerSymlinksPath *string `json:"ContainerSymlinksPath,omitempty"` | |||
| ContainerSymlinksPath *string `json:"containerSymlinksPath,omitempty"` | |||
CharlyF
reviewed
Sep 13, 2021
| @@ -722,6 +722,9 @@ type ConfigDirSpec struct { | |||
| // ConfigMapName name of a ConfigMap used to mount a directory. | |||
| ConfigMapName string `json:"configMapName,omitempty"` | |||
| // items mapping between configMap data key and file path mount. | |||
| // +optional | |||
| // +listType=map | |||
| // +listMapKey=key | |||
| Items []corev1.KeyToPath `json:"items,omitempty"` | |||
CharlyF
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.