Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test conductor for custom image #1523

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Nov 12, 2024

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m force-pushed the levan-m/conductor_testing_branch branch from ea3ec22 to cc7cee2 Compare November 12, 2024 21:17
@levan-m levan-m added this to the v1.11.0 milestone Nov 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.32%. Comparing base (54f43d1) to head (336503e).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   48.86%   49.32%   +0.45%     
==========================================
  Files         225      226       +1     
  Lines       19959    20344     +385     
==========================================
+ Hits         9753    10034     +281     
- Misses       9695     9787      +92     
- Partials      511      523      +12     
Flag Coverage Δ
unittests 49.32% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f43d1...336503e. Read the comment docs.

@levan-m levan-m modified the milestones: v1.11.0, v1.12.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants