-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement label and annotation equality checking #1467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 48.94% 48.86% -0.08%
==========================================
Files 223 223
Lines 19758 19756 -2
==========================================
- Hits 9670 9654 -16
- Misses 9578 9595 +17
+ Partials 510 507 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor typo on last test
Co-authored-by: Timothée Bavelier <[email protected]>
* Implement label and annotation equality checking * Update pkg/equality/equality_test.go Co-authored-by: Timothée Bavelier <[email protected]> --------- Co-authored-by: Timothée Bavelier <[email protected]>
* Implement label and annotation equality checking * Update pkg/equality/equality_test.go --------- Co-authored-by: Timothée Bavelier <[email protected]>
What does this PR do?
Implements checking for differences in annotations and labels for objects.
Motivation
Unable to update service account annotations when qa'ing #1425
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label