Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ability to disable or specify custom host ports for OTLP #1440

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

mrdoggopat
Copy link
Contributor

What does this PR do?

Add the ability to disable host ports for OTLP and specify custom host ports.

Motivation

CECO-663
#903

Anything else we should know when reviewing?
N/A

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
N/A

Describe your test plan

Play around with the following DatadogAgent configuration:

spec:
  features:
    otlp:
      receiver:
        protocols:
          grpc:
            enabled: true
            hostPortConfig:
              enabled: <true or false>
              hostPort: <host port>
          http:
            enabled: true
            hostPortConfig:
              enabled: <true or false>
              hostPort: <host port>

Run kubectl describe pod <node agent pod> and see if the behavior reflects.

For running the node agent in a single container:

spec:
  global:
    containerStrategy: single
  features:
    otlp:
      receiver:
        protocols:
          grpc:
            enabled: true
            hostPortConfig:
              enabled: <true or false>
              hostPort: <host port>
          http:
            enabled: true
            hostPortConfig:
              enabled: <true or false>
              hostPort: <host port>

Run kubectl describe pod <node agent pod> and see if the behavior reflects.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@mrdoggopat mrdoggopat added the enhancement New feature or request label Sep 26, 2024
@mrdoggopat mrdoggopat added this to the v1.10.0 milestone Sep 26, 2024
@mrdoggopat mrdoggopat requested review from a team as code owners September 26, 2024 22:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (0d97b8a) to head (5690a73).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
+ Coverage   48.89%   49.01%   +0.12%     
==========================================
  Files         223      223              
  Lines       19455    19501      +46     
==========================================
+ Hits         9513     9559      +46     
  Misses       9453     9453              
  Partials      489      489              
Flag Coverage Δ
unittests 49.01% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/datadogagent_default.go 89.74% <100.00%> (+0.36%) ⬆️
api/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)
api/datadoghq/v2alpha1/test/builder.go 91.94% <100.00%> (+0.11%) ⬆️
...al/controller/datadogagent/feature/otlp/feature.go 63.79% <100.00%> (+4.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d97b8a...5690a73. Read the comment docs.

@mrdoggopat mrdoggopat changed the title Mrmcpat otlp hostport toggle Allow the ability to disable or specify custom host ports for OTLP Sep 26, 2024
@mrdoggopat mrdoggopat merged commit 7fe7979 into main Oct 4, 2024
19 checks passed
@mrdoggopat mrdoggopat deleted the mrmcpat-otlp-hostport-toggle branch October 4, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants