Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to eds options if needed (#1414) #1419

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Sep 13, 2024

What does this PR do?

Cherry pick #1414

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added enhancement New feature or request qa/skip-qa labels Sep 13, 2024
@khewonc khewonc added this to the v1.9.0 milestone Sep 13, 2024
@khewonc khewonc requested a review from a team as a code owner September 13, 2024 16:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (f046e4a) to head (20309da).
Report is 8 commits behind head on v1.9.

Files with missing lines Patch % Lines
...nal/controller/datadogagent/component/agent/new.go 0.00% 4 Missing ⚠️
pkg/agentprofile/agent_profile.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             v1.9    #1419      +/-   ##
==========================================
+ Coverage   47.40%   49.01%   +1.60%     
==========================================
  Files         223      223              
  Lines       19244    19251       +7     
==========================================
+ Hits         9123     9435     +312     
+ Misses       9635     9333     -302     
+ Partials      486      483       -3     
Flag Coverage Δ
unittests 49.01% <50.00%> (+1.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/utils/utils.go 4.34% <100.00%> (-66.87%) ⬇️
...controller/datadogagent/controller_reconcile_v2.go 53.91% <100.00%> (ø)
...nal/controller/datadogagent/component/agent/new.go 20.83% <0.00%> (+16.83%) ⬆️
pkg/agentprofile/agent_profile.go 71.63% <50.00%> (-0.59%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f046e4a...20309da. Read the comment docs.

@khewonc khewonc merged commit f7ef0be into v1.9 Sep 13, 2024
16 checks passed
@khewonc khewonc deleted the khewonc/cherry-pick-1414 branch September 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants