Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profiles] Rename slow start to create strategy #1416

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Sep 12, 2024

What does this PR do?

Change slow start to create strategy

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Check that the DAP CRD uses create strategy instead of slow start

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added the enhancement New feature or request label Sep 12, 2024
@khewonc khewonc added this to the v1.9.0 milestone Sep 12, 2024
@khewonc khewonc requested a review from a team as a code owner September 12, 2024 21:12
@khewonc khewonc changed the title [profiles] Change slow start to create strategy [profiles] Rename slow start to create strategy Sep 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 24 lines in your changes missing coverage. Please review.

Project coverage is 47.40%. Comparing base (2889617) to head (1d5c014).

Files with missing lines Patch % Lines
pkg/agentprofile/agent_profile.go 30.43% 14 Missing and 2 partials ⚠️
...ler/datadogagent/controller_reconcile_v2_common.go 27.27% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         223      223           
  Lines       19244    19244           
=======================================
  Hits         9123     9123           
  Misses       9635     9635           
  Partials      486      486           
Flag Coverage Δ
unittests 47.40% <42.85%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pi/datadoghq/v1alpha1/datadogagentprofile_types.go 100.00% <ø> (ø)
pkg/agentprofile/status.go 100.00% <100.00%> (ø)
...ler/datadogagent/controller_reconcile_v2_common.go 29.96% <27.27%> (ø)
pkg/agentprofile/agent_profile.go 72.22% <30.43%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2889617...1d5c014. Read the comment docs.

@khewonc khewonc merged commit 5fa757b into main Sep 13, 2024
21 checks passed
@khewonc khewonc deleted the khewonc/slowstart-createstrategy branch September 13, 2024 16:41
khewonc added a commit that referenced this pull request Sep 13, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants