Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dependencies pkg to store #1400

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Small PR to rename controllers/datadogagent/dependencies to controllers/datadogagent/store, since this code houses the Store object and there is a different meaning for dependencies in the agent controller elsewhere.

Changes are noop.

Replaces #1390

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

The change should be noop - make sure the operator can be built and runs without errors

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added this to the v1.10.0 milestone Sep 10, 2024
@celenechang celenechang requested review from a team as code owners September 10, 2024 15:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 47.40%. Comparing base (6d4bbd9) to head (3bce1dd).

Files with missing lines Patch % Lines
.../controller/datadogagent/feature/test/testsuite.go 0.00% 3 Missing ⚠️
internal/controller/datadogagent/feature/types.go 0.00% 2 Missing ⚠️
internal/controller/datadogagent/store/store.go 66.66% 2 Missing ⚠️
...ernal/controller/datadogagent/merger/apiservice.go 0.00% 1 Missing ⚠️
internal/controller/datadogagent/merger/cilium.go 0.00% 1 Missing ⚠️
...ternal/controller/datadogagent/merger/configmap.go 0.00% 1 Missing ⚠️
...l/controller/datadogagent/merger/network_policy.go 0.00% 1 Missing ⚠️
...nal/controller/datadogagent/merger/pod_security.go 0.00% 1 Missing ⚠️
internal/controller/datadogagent/merger/rbac.go 0.00% 1 Missing ⚠️
internal/controller/datadogagent/merger/secret.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1400   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files         223      223           
  Lines       19244    19244           
=======================================
  Hits         9123     9123           
  Misses       9635     9635           
  Partials      486      486           
Flag Coverage Δ
unittests 47.40% <34.78%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/controller_reconcile_v2.go 53.91% <100.00%> (ø)
internal/controller/datadogagent/finalizer.go 56.43% <100.00%> (ø)
...ernal/controller/datadogagent/merger/apiservice.go 0.00% <0.00%> (ø)
internal/controller/datadogagent/merger/cilium.go 44.00% <0.00%> (ø)
...ternal/controller/datadogagent/merger/configmap.go 42.85% <0.00%> (ø)
...l/controller/datadogagent/merger/network_policy.go 50.00% <0.00%> (ø)
...nal/controller/datadogagent/merger/pod_security.go 0.00% <0.00%> (ø)
internal/controller/datadogagent/merger/rbac.go 31.97% <0.00%> (ø)
internal/controller/datadogagent/merger/secret.go 60.71% <0.00%> (ø)
internal/controller/datadogagent/merger/service.go 63.63% <0.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4bbd9...3bce1dd. Read the comment docs.

@celenechang celenechang merged commit 2a7b83c into main Sep 12, 2024
19 checks passed
@celenechang celenechang deleted the celene/rename_dependencies branch September 12, 2024 16:46
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants