-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] reorganize rbac-related methods #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celenechang
force-pushed
the
celene/serviceaccount_cleanup
branch
from
August 13, 2024 15:07
4d5529f
to
e00c3e1
Compare
fanny-jiang
approved these changes
Aug 16, 2024
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* [cleanup] reorganize rbac-related methods * separate out networks into objects * small fix
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* [cleanup] reorganize rbac-related methods * separate out networks into objects * small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
enabledefault
feature intoenabledefault/rbac.go
enabledefault
feature intoenabledefault/configmap.go
github.com/DataDog/datadog-operator/controllers/datadogagent/component/utils.go
togithub.com/DataDog/datadog-operator/controllers/datadogagent/common
, and have this package be "lowest" (doesn't import from most other operator packages)github.com/DataDog/datadog-operator/controllers/datadogagent/component/objects
, since one of these methods requires importing from the component files. Unfortunately can't group it with the volume functions because that results in a dependency loop.Planned future work: see if we can consolidate
common
filesMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label