Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooling] Remove some OpenAPI warning and docker build warning #1336

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[Tooling] Remove some OpenAPI warning and docker build warning #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apis/datadoghq/v1alpha1/datadogmonitor_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ type DatadogMonitorOptions struct {
// cluster violating the alert conditions by setting notify_by to ["cluster"]. Tags mentioned in notify_by must
// be a subset of the grouping tags in the query. For example, a query grouped by cluster and namespace cannot
// notify on region. Setting notify_by to [*] configures the monitor to notify as a simple-alert.
// +listType=set
NotifyBy []string `json:"notifyBy,omitempty"`
// A Boolean indicating whether this monitor notifies when data stops reporting.
NotifyNoData *bool `json:"notifyNoData,omitempty"`
Expand All @@ -128,6 +129,7 @@ type DatadogMonitorOptions struct {
// The number of times re-notification messages should be sent on the current status at the provided re-notification interval.
RenotifyOccurrences *int64 `json:"renotifyOccurrences,omitempty"`
// The types of statuses for which re-notification messages should be sent. Valid values are alert, warn, no data.
// +listType=set
RenotifyStatuses []datadogV1.MonitorRenotifyStatusType `json:"renotifyStatuses,omitempty"`
// A Boolean indicating whether this monitor needs a full window of data before it’s evaluated. We highly
// recommend you set this to false for sparse metrics, otherwise some evaluations are skipped. Default is false.
Expand Down
10 changes: 10 additions & 0 deletions apis/datadoghq/v1alpha1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion check-operator.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1.22 as builder
FROM golang:1.22 AS builder

WORKDIR /workspace
# Copy the Go Modules manifests
Expand Down
2 changes: 2 additions & 0 deletions config/crd/bases/v1/datadoghq.com_datadogmonitors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ spec:
items:
type: string
type: array
x-kubernetes-list-type: set
notifyNoData:
description: A Boolean indicating whether this monitor notifies when data stops reporting.
type: boolean
Expand Down Expand Up @@ -153,6 +154,7 @@ spec:
description: MonitorRenotifyStatusType The different statuses for which renotification is supported.
type: string
type: array
x-kubernetes-list-type: set
requireFullWindow:
description: |-
A Boolean indicating whether this monitor needs a full window of data before it’s evaluated. We highly
Expand Down
Loading