Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] rm v2 from function names in metrics forwarder #1313

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Additional cleanup following v1alpha2 deprecation

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added this to the v1.9.0 milestone Jul 24, 2024
@celenechang celenechang requested a review from a team as a code owner July 24, 2024 18:50
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.34%. Comparing base (46c0dd2) to head (630fb6b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   47.34%   47.34%           
=======================================
  Files         230      230           
  Lines       22027    22027           
=======================================
  Hits        10429    10429           
  Misses      11008    11008           
  Partials      590      590           
Flag Coverage Δ
unittests 47.34% <22.22%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/utils/datadog/metrics_forwarder.go 31.07% <22.22%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c0dd2...630fb6b. Read the comment docs.

@celenechang celenechang merged commit 5b81186 into main Jul 24, 2024
21 checks passed
@celenechang celenechang deleted the celene/truncate_v2_funcs branch July 24, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants