Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more profiler types #1310

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add more profiler types #1310

merged 1 commit into from
Jul 24, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Jul 24, 2024

What does this PR do?

Add more profiler types to profiling

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added the enhancement New feature or request label Jul 24, 2024
@khewonc khewonc added this to the v1.8.0 milestone Jul 24, 2024
@khewonc khewonc requested a review from a team as a code owner July 24, 2024 16:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (b22228f) to head (d960a1a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   55.21%   55.19%   -0.02%     
==========================================
  Files         247      247              
  Lines       28384    28390       +6     
==========================================
  Hits        15671    15671              
- Misses      11827    11833       +6     
  Partials      886      886              
Flag Coverage Δ
unittests 55.19% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
main.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22228f...d960a1a. Read the comment docs.

@khewonc khewonc merged commit 204ff10 into main Jul 24, 2024
21 checks passed
@khewonc khewonc deleted the khewonc/add-profiler-types branch July 24, 2024 16:33
levan-m pushed a commit that referenced this pull request Jul 25, 2024
@levan-m levan-m mentioned this pull request Jul 25, 2024
2 tasks
levan-m added a commit that referenced this pull request Jul 26, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants