Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Language Detection struct #1307

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Renaming LanguageDetection to LanguageDetectionConfig in the types file for consistency.

This is noop to the user as the json tag is unchanged.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added this to the v1.8.0 milestone Jul 23, 2024
@celenechang celenechang requested review from a team as code owners July 23, 2024 14:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.20%. Comparing base (1c66029) to head (6026e8c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   55.20%   55.20%           
=======================================
  Files         247      247           
  Lines       28383    28383           
=======================================
  Hits        15670    15670           
  Misses      11827    11827           
  Partials      886      886           
Flag Coverage Δ
unittests 55.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/datadoghq/v2alpha1/datadogagent_default.go 89.31% <100.00%> (ø)
apis/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)
apis/datadoghq/v2alpha1/test/builder.go 91.44% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c66029...6026e8c. Read the comment docs.

@celenechang celenechang merged commit b22228f into main Jul 24, 2024
21 checks passed
@celenechang celenechang deleted the celene/language_detection_struct branch July 24, 2024 15:01
celenechang added a commit that referenced this pull request Jul 24, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants