Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use service catalog schema version v2 #1297

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

celenechang
Copy link
Contributor

@celenechang celenechang commented Jul 17, 2024

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (9f46425) to head (c10f1c2).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   55.17%   55.55%   +0.38%     
==========================================
  Files         246      247       +1     
  Lines       28285    28572     +287     
==========================================
+ Hits        15606    15873     +267     
- Misses      11800    11811      +11     
- Partials      879      888       +9     
Flag Coverage Δ
unittests 55.55% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f46425...c10f1c2. Read the comment docs.

@celenechang celenechang merged commit 6d6f73d into main Jul 17, 2024
23 checks passed
@celenechang celenechang deleted the celene/update_service_schema branch July 17, 2024 18:00
mftoure pushed a commit that referenced this pull request Oct 3, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants