Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service catalog file #1293

Merged
merged 1 commit into from
Jul 16, 2024
Merged

add service catalog file #1293

merged 1 commit into from
Jul 16, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Add Datadog Operator service catalog file

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

service-url: https://datadog.pagerduty.com/service-directory/PFZC0QZ
extensions:
datadoghq.com/sdp:
conductor:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this currently does nothing, first i want to verify that the service is ack'd by conductor

- type: slack
contact: https://dd.slack.com/archives/C037CDX0WJV
- type: email
contact: [email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be updated at a later time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.06%. Comparing base (78cefd3) to head (ba90f6a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1293   +/-   ##
=======================================
  Coverage   55.06%   55.06%           
=======================================
  Files         244      244           
  Lines       28177    28177           
=======================================
  Hits        15517    15517           
  Misses      11783    11783           
  Partials      877      877           
Flag Coverage Δ
unittests 55.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78cefd3...ba90f6a. Read the comment docs.

@celenechang celenechang merged commit 77dc150 into main Jul 16, 2024
19 checks passed
@celenechang celenechang deleted the celene/add_service_file branch July 16, 2024 19:17
mftoure pushed a commit that referenced this pull request Oct 3, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants