Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default agent test #1282

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix default agent test #1282

merged 1 commit into from
Jul 10, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Small fix for a test

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added bug Something isn't working qa/skip-qa labels Jul 10, 2024
@celenechang celenechang requested review from a team as code owners July 10, 2024 14:25
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.97%. Comparing base (26e9e9f) to head (452549b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   54.88%   54.97%   +0.08%     
==========================================
  Files         241      243       +2     
  Lines       27931    27986      +55     
==========================================
+ Hits        15331    15386      +55     
  Misses      11730    11730              
  Partials      870      870              
Flag Coverage Δ
unittests 54.97% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ac9d1...452549b. Read the comment docs.

@celenechang celenechang merged commit 70315d8 into main Jul 10, 2024
23 checks passed
@celenechang celenechang deleted the celene/fix_test branch July 10, 2024 14:43
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants