Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bundle examples #1260

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix bundle examples #1260

merged 1 commit into from
Jul 3, 2024

Conversation

celenechang
Copy link
Contributor

@celenechang celenechang commented Jul 2, 2024

What does this PR do?

Properly fix bundle examples following #1258
Update DatadogAgent bundle example to include recommended settings for Openshift

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.87%. Comparing base (89609b1) to head (fcc0713).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files         241      241           
  Lines       27893    27893           
=======================================
  Hits        15305    15305           
  Misses      11717    11717           
  Partials      871      871           
Flag Coverage Δ
unittests 54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89609b1...fcc0713. Read the comment docs.

@celenechang celenechang merged commit 2abf8c7 into main Jul 3, 2024
23 checks passed
@celenechang celenechang deleted the celene/bundle_ex branch July 3, 2024 16:10
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants