-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadogmonitor] Adding renotifyStatuses and indicating Locked is deprecated #1259
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 55.03% 55.04%
=======================================
Files 243 243
Lines 28165 28168 +3
=======================================
+ Hits 15502 15505 +3
Misses 11785 11785
Partials 878 878
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
…recated (#1259) * added renotifyStatuses and removed deprecated Locked in monitors * removed redundant operation * revereted Locked delete * Update apis/datadoghq/v1alpha1/datadogmonitor_types.go Co-authored-by: Celene <[email protected]> * regenerating CRDs --------- Co-authored-by: levan-m <[email protected]> Co-authored-by: Celene <[email protected]>
…recated (#1259) * added renotifyStatuses and removed deprecated Locked in monitors * removed redundant operation * revereted Locked delete * Update apis/datadoghq/v1alpha1/datadogmonitor_types.go Co-authored-by: Celene <[email protected]> * regenerating CRDs --------- Co-authored-by: levan-m <[email protected]> Co-authored-by: Celene <[email protected]>
What does this PR do?
A brief description of the change being made with this pull request.
Added renotifyStatuses to the operator's datadog monitor field, and removed
Locked
which is deprecatedMotivation
What inspired you to submit this pull request?
#1216
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
I used this manifest after enabling datadogmonitors in datadog operator manager.yaml file:
The renotifyStatuses were subsequently shown on the monitor's settings:
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label