Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[external metrics] fix configuration when registerAPIService is false #1255

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

When the External Metrics Server is set to not register an API Service, we were not creating other RBACs needed for the EMS. This PR fixes that issue.

Motivation

Bug fix

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added the bug Something isn't working label Jul 1, 2024
@celenechang celenechang added this to the v1.8.0 milestone Jul 1, 2024
@celenechang celenechang requested review from a team as code owners July 1, 2024 15:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (7a522d3) to head (6f48203).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   54.87%   54.87%           
=======================================
  Files         241      241           
  Lines       27893    27893           
=======================================
  Hits        15305    15305           
  Misses      11717    11717           
  Partials      871      871           
Flag Coverage Δ
unittests 54.87% <30.76%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rs/datadogagent/feature/externalmetrics/feature.go 41.88% <30.76%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a522d3...6f48203. Read the comment docs.

@celenechang celenechang merged commit f14c8d4 into main Jul 2, 2024
21 checks passed
@celenechang celenechang deleted the celene/fix_ems branch July 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants