-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[profiles] Improve DAP name length error #1254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 54.98% 55.01% +0.02%
==========================================
Files 243 243
Lines 27986 28002 +16
==========================================
+ Hits 15388 15404 +16
Misses 11729 11729
Partials 869 869
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: levan-m <[email protected]>
* Rename profile label key * Remove old profile label * Review suggestions * Check for profile name length * Update pkg/agentprofile/agent_profile.go Co-authored-by: levan-m <[email protected]> --------- Co-authored-by: levan-m <[email protected]>
What does this PR do?
If a profile name is too long, older versions of the operator would run into an error attempting to label the node, leading to this error:
It can be unexpected that the operator would complain about node labels when applying a profile. Instead, we now invalidate the profile and output an error message that clarifies that the profile name is the issue.
Motivation
https://datadoghq.atlassian.net/browse/CECO-1187
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label