Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] add support for multiarch images in redhat #1252

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

celenechang
Copy link
Contributor

@celenechang celenechang commented Jun 27, 2024

What does this PR do?

  • Update publish redhat jobs to use public-images tool
  • Consolidate preflight checks into one. This now supports a multiarch image, so we will run the check/submit together with the pushed Redhat image after it's been pushed.
  • Update CSV labels to indicate arch support

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added this to the v1.8.0 milestone Jun 27, 2024
@celenechang celenechang requested review from a team as code owners June 27, 2024 18:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.34%. Comparing base (d0935d7) to head (d9be8a3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   55.32%   55.34%   +0.01%     
==========================================
  Files         241      241              
  Lines       27889    27919      +30     
==========================================
+ Hits        15430    15451      +21     
- Misses      11587    11595       +8     
- Partials      872      873       +1     
Flag Coverage Δ
unittests 55.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0935d7...d9be8a3. Read the comment docs.

@celenechang celenechang merged commit b026d74 into main Jul 3, 2024
19 checks passed
@celenechang celenechang deleted the celene/push_redhat_multiarch branch July 3, 2024 15:22
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* [gitlab] add support for multiarch images in redhat

* add labels

* modify envvar

* use multiarch image for preflight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants