Remove DatadogAgent v1alpha1 CRD version and conversion webhook #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
levan-m
force-pushed
the
levan-m/skip-dda-v1alpha1
branch
from
e33f740
to
ab84fc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage ? 59.29%
=======================================
Files ? 177
Lines ? 22380
Branches ? 0
=======================================
Hits ? 13270
Misses ? 8298
Partials ? 812
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
hestonhoffman
approved these changes
Jun 21, 2024
fanny-jiang
approved these changes
Jun 24, 2024
levan-m
commented
Jun 24, 2024
| @@ -1405,7 +1405,6 @@ const ( | |||
|
|
|||
| // DatadogAgent Deployment with Datadog Operator. | |||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:subresource:status | |||
There was a problem hiding this comment.
Without deleting this line, controller-gen fails with below error. Since v1alpha1 is getting deprecated in this release I don't removing this as a problem so didn't debug it any further
❯ bin/darwin-arm64/controller-gen "crd:preserveUnknownFields=false",crdVersions=v1 rbac:roleName=manager-role paths="./apis/..." output:crd:artifacts:config=config/crd/bases/v1
[repo_root]/apis/datadoghq/v1alpha1/datadogagent_types.go:1418:6: status subresource applied to version "v1alpha1" not in CRD
Error: not all generators ran successfully
khewonc
approved these changes
Jun 24, 2024
4 tasks
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Remove DatadogAgent v1alpha1 CRD version * Remove option of enabling conversion webhook * Don't generate DatadogAgent v1alpha1 doc * Skip DatadogAgent v1alpha1 suite test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DatadogAgentv1alpha1CRD.This PR doesn't clean up the Go code.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel