-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DatadogAgent v1alpha1 CRD version and conversion webhook #1242
Conversation
e33f740
to
ab84fc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage ? 59.29%
=======================================
Files ? 177
Lines ? 22380
Branches ? 0
=======================================
Hits ? 13270
Misses ? 8298
Partials ? 812
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@@ -1405,7 +1405,6 @@ const ( | |||
|
|||
// DatadogAgent Deployment with Datadog Operator. | |||
// +kubebuilder:object:root=true | |||
// +kubebuilder:subresource:status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without deleting this line, controller-gen
fails with below error. Since v1alpha1
is getting deprecated in this release I don't removing this as a problem so didn't debug it any further
❯ bin/darwin-arm64/controller-gen "crd:preserveUnknownFields=false",crdVersions=v1 rbac:roleName=manager-role paths="./apis/..." output:crd:artifacts:config=config/crd/bases/v1
[repo_root]/apis/datadoghq/v1alpha1/datadogagent_types.go:1418:6: status subresource applied to version "v1alpha1" not in CRD
Error: not all generators ran successfully
* Remove DatadogAgent v1alpha1 CRD version * Remove option of enabling conversion webhook * Don't generate DatadogAgent v1alpha1 doc * Skip DatadogAgent v1alpha1 suite test
What does this PR do?
DatadogAgent
v1alpha1
CRD.This PR doesn't clean up the Go code.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label