Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1184] Add tool version for community operators #1221

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Jun 5, 2024

What does this PR do?

Add custom tool version for community operators. Key is DD_TOOL_VERSION, value changes based on the bundle:

  1. k8s-operatorhub/community-operators: operatorhub
  2. community-operators-prod: redhat
  3. redhat-marketplace-operators: redhat
  4. certified-operators: redhat

Motivation

CECO-1184

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Run the bundle command make VERSION=X.Y.Z LATEST_VERSION=X.Y.Z bundle and check that the DD_TOOL_VERSION env var is in the bundle and bundle-community-operators clusterserviceversion files. The bundle's value should be redhat. The bundle-community-operators's value should be operatorhub
  • Run make bundle-redhat (X.Y.Z must be an existing image tag in the redhat registry) and check that the DD_TOOL_VERSION env var is present in the bundle-redhat and bundle-redhat-marketplace csv files with value redhat

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added the enhancement New feature or request label Jun 5, 2024
@khewonc khewonc added this to the v1.7.0 milestone Jun 5, 2024
@khewonc khewonc requested review from a team as code owners June 5, 2024 19:37
@khewonc khewonc merged commit c46b61d into main Jun 7, 2024
21 checks passed
@khewonc khewonc deleted the khewonc/tool-version-comm-op branch June 7, 2024 21:10
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants