-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CECO-1106] DDA config for Admission Controller sidecar injection using selector and profile #1209
[CECO-1106] DDA config for Admission Controller sidecar injection using selector and profile #1209
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
+ Coverage 59.33% 59.53% +0.20%
==========================================
Files 176 177 +1
Lines 22124 22322 +198
==========================================
+ Hits 13127 13290 +163
- Misses 8192 8219 +27
- Partials 805 813 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
controllers/datadogagent/feature/admissioncontroller/feature.go
Outdated
Show resolved
Hide resolved
controllers/datadogagent/feature/admissioncontroller/feature.go
Outdated
Show resolved
Hide resolved
controllers/datadogagent/feature/admissioncontroller/feature.go
Outdated
Show resolved
Hide resolved
controllers/datadogagent/feature/admissioncontroller/feature.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small suggestions
…ng selector and profile (#1209) * Adding selectors and profiles * changing some terms and Editing selector profile logics in AC feature * Editing some comments on types, chaning profile logic in feature * Repositioning AgentSidecarInjectionConfig in type * Editing some terms in selector and profile type * Adding generate code /merge
…ng selector and profile (#1209) (#1229) * Adding selectors and profiles * changing some terms and Editing selector profile logics in AC feature * Editing some comments on types, chaning profile logic in feature * Repositioning AgentSidecarInjectionConfig in type * Editing some terms in selector and profile type * Adding generate code /merge Co-authored-by: kisungyi92 <[email protected]>
…ng selector and profile (#1209) * Adding selectors and profiles * changing some terms and Editing selector profile logics in AC feature * Editing some comments on types, chaning profile logic in feature * Repositioning AgentSidecarInjectionConfig in type * Editing some terms in selector and profile type * Adding generate code /merge
What does this PR do?
This PR is following up PR #1207 adding selectors and profiles.
Motivation
CECO-1067
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Test based on the release v1.6.0
selectors.objectSelector
option in admissionController.agentSidecarInjection.selectors.namespaceSelector
with same structure.DD_ADMISSION_CONTROLLER_AGENT_SIDECAR_SELECTORS
is set to correct map structure.profiles
option in admissionController.agentSidecarInjection.DD_ADMISSION_CONTROLLER_AGENT_SIDECAR_PROFILES
is set to correct map structure.Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label