-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[profile][CECO-795] Add dap status #1155
Conversation
940df86
to
79a1a8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
+ Coverage 59.23% 59.48% +0.25%
==========================================
Files 176 177 +1
Lines 22040 22275 +235
==========================================
+ Hits 13055 13251 +196
- Misses 8184 8219 +35
- Partials 801 805 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* Add dap status * Review suggestions * Fix tests
* Add dap status * Review suggestions * Fix tests
What does this PR do?
Adds basic status to DAP.
kubectl get
kubectl describe
Motivation
What inspired you to submit this pull request?
Additional Notes
Valid
andApplied
are added as both conditions and separate fields in the dap status. Conditions can give more detail on a potential error and separate fields allow them to be listed in thekubectl get
outputMinimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
profileNodeAffinity
-> go back to valid dapChecklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label