[remote config] move initialization to be independent of agent reconciler #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
celenechang
commented
Apr 17, 2024
| --- | ||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.14.0 | ||
| controller-gen.kubebuilder.io/version: v0.6.1 | ||
| creationTimestamp: null |
There was a problem hiding this comment.
these generated file changes seem to line up with main
hestonhoffman
approved these changes
Apr 17, 2024
celenechang
added a commit
that referenced
this pull request
Jun 6, 2024
* [add-remote-config] initial commit (#1126) * Draft of service activation through RC * various refactoring and updates * use CWS_DD product, update logger, add statecallbacks --------- Co-authored-by: Sylvain Baubeau <[email protected]> * Use agent config for service activation (#1134) * [remote-config] set up test config * change product to AgentConfig * small edits * Refactor and bump controller-tools version * Test with mocked Config * Test e2e * Merge configs * Merge configs, send Acknowledges * Add service initialisation in reconcilier * Fix tags initialisation * Fix validation tests * Fix build test error --------- Co-authored-by: Celene <[email protected]> * Add usm service activation (#1141) * Add usm service activation * Read CWS config from system-probe and CSPM from security-agent * Read CWS config from system-probe and CSPM from security-agent * Add DDSystemProbeServiceMonitoringEnabled to coreAgent container * move initialization to be independent of agent reconciler (#1142) * cleanup unneeded changes (#1149) * [remote-config] add envvars missing from core agent for system probe features (#1170) * [remote-config] sysprobe socket fixes * add sysprobe envvars to core container * add sys probe enabled envvar to where missing * Fix angeConfig struct (#1187) * [remote-config] store RC config in dda status (#1196) * [remote-config] store RC config in dda status * add layer to config stored in status, apply updates in reconcile feature code * fix feature config references * small comment update * a little cleanup * update modules * fix licenses * fix tests * updated generated files * rm two licenses * small fixes * properly merge remoteconfig config * simplify * update comment --------- Co-authored-by: Sylvain Baubeau <[email protected]> Co-authored-by: Momar TOURÉ <[email protected]>
celenechang
added a commit
that referenced
this pull request
Jun 6, 2024
* [add-remote-config] initial commit (#1126) * Draft of service activation through RC * various refactoring and updates * use CWS_DD product, update logger, add statecallbacks --------- Co-authored-by: Sylvain Baubeau <[email protected]> * Use agent config for service activation (#1134) * [remote-config] set up test config * change product to AgentConfig * small edits * Refactor and bump controller-tools version * Test with mocked Config * Test e2e * Merge configs * Merge configs, send Acknowledges * Add service initialisation in reconcilier * Fix tags initialisation * Fix validation tests * Fix build test error --------- Co-authored-by: Celene <[email protected]> * Add usm service activation (#1141) * Add usm service activation * Read CWS config from system-probe and CSPM from security-agent * Read CWS config from system-probe and CSPM from security-agent * Add DDSystemProbeServiceMonitoringEnabled to coreAgent container * move initialization to be independent of agent reconciler (#1142) * cleanup unneeded changes (#1149) * [remote-config] add envvars missing from core agent for system probe features (#1170) * [remote-config] sysprobe socket fixes * add sysprobe envvars to core container * add sys probe enabled envvar to where missing * Fix angeConfig struct (#1187) * [remote-config] store RC config in dda status (#1196) * [remote-config] store RC config in dda status * add layer to config stored in status, apply updates in reconcile feature code * fix feature config references * small comment update * a little cleanup * update modules * fix licenses * fix tests * updated generated files * rm two licenses * small fixes * properly merge remoteconfig config * simplify * update comment --------- Co-authored-by: Sylvain Baubeau <[email protected]> Co-authored-by: Momar TOURÉ <[email protected]>
celenechang
added a commit
that referenced
this pull request
Jun 6, 2024
* [beta] Add remote config (#1215) * [add-remote-config] initial commit (#1126) * Draft of service activation through RC * various refactoring and updates * use CWS_DD product, update logger, add statecallbacks --------- Co-authored-by: Sylvain Baubeau <[email protected]> * Use agent config for service activation (#1134) * [remote-config] set up test config * change product to AgentConfig * small edits * Refactor and bump controller-tools version * Test with mocked Config * Test e2e * Merge configs * Merge configs, send Acknowledges * Add service initialisation in reconcilier * Fix tags initialisation * Fix validation tests * Fix build test error --------- Co-authored-by: Celene <[email protected]> * Add usm service activation (#1141) * Add usm service activation * Read CWS config from system-probe and CSPM from security-agent * Read CWS config from system-probe and CSPM from security-agent * Add DDSystemProbeServiceMonitoringEnabled to coreAgent container * move initialization to be independent of agent reconciler (#1142) * cleanup unneeded changes (#1149) * [remote-config] add envvars missing from core agent for system probe features (#1170) * [remote-config] sysprobe socket fixes * add sysprobe envvars to core container * add sys probe enabled envvar to where missing * Fix angeConfig struct (#1187) * [remote-config] store RC config in dda status (#1196) * [remote-config] store RC config in dda status * add layer to config stored in status, apply updates in reconcile feature code * fix feature config references * small comment update * a little cleanup * update modules * fix licenses * fix tests * updated generated files * rm two licenses * small fixes * properly merge remoteconfig config * simplify * update comment --------- Co-authored-by: Sylvain Baubeau <[email protected]> Co-authored-by: Momar TOURÉ <[email protected]> * fix generated files --------- Co-authored-by: Sylvain Baubeau <[email protected]> Co-authored-by: Momar TOURÉ <[email protected]>
mftoure
added a commit
that referenced
this pull request
Oct 3, 2024
* [add-remote-config] initial commit (#1126) * Draft of service activation through RC * various refactoring and updates * use CWS_DD product, update logger, add statecallbacks --------- Co-authored-by: Sylvain Baubeau <[email protected]> * Use agent config for service activation (#1134) * [remote-config] set up test config * change product to AgentConfig * small edits * Refactor and bump controller-tools version * Test with mocked Config * Test e2e * Merge configs * Merge configs, send Acknowledges * Add service initialisation in reconcilier * Fix tags initialisation * Fix validation tests * Fix build test error --------- Co-authored-by: Celene <[email protected]> * Add usm service activation (#1141) * Add usm service activation * Read CWS config from system-probe and CSPM from security-agent * Read CWS config from system-probe and CSPM from security-agent * Add DDSystemProbeServiceMonitoringEnabled to coreAgent container * move initialization to be independent of agent reconciler (#1142) * cleanup unneeded changes (#1149) * [remote-config] add envvars missing from core agent for system probe features (#1170) * [remote-config] sysprobe socket fixes * add sysprobe envvars to core container * add sys probe enabled envvar to where missing * Fix angeConfig struct (#1187) * [remote-config] store RC config in dda status (#1196) * [remote-config] store RC config in dda status * add layer to config stored in status, apply updates in reconcile feature code * fix feature config references * small comment update * a little cleanup * update modules * fix licenses * fix tests * updated generated files * rm two licenses * small fixes * properly merge remoteconfig config * simplify * update comment --------- Co-authored-by: Sylvain Baubeau <[email protected]> Co-authored-by: Momar TOURÉ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move initialization of RC to outside of agent reconcile loop
Add a flag to enable the RC service in main.go
Simplify the
endpointdetermination a bitReorder functions in updater.go a bit
(Generated file changes seem to match what's in
main, I will also plan to mergemaininto this branch soon)Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel