Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatadogPodAutoscaler resource #1118

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

vboulineau
Copy link
Contributor

@vboulineau vboulineau commented Mar 12, 2024

What does this PR do?

Add DatadogPodAutoscaler CRD.

Motivation

Product.

Additional Notes

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Cluster Agent: v7.56

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (c72fc48) to head (ad7c41f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         243      244    +1     
  Lines       28031    28033    +2     
=======================================
+ Hits        15412    15414    +2     
  Misses      11747    11747           
  Partials      872      872           
Flag Coverage Δ
unittests 54.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/datadoghq/v1alpha1/datadogpodautoscaler_types.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72fc48...ad7c41f. Read the comment docs.

@vboulineau vboulineau added the enhancement New feature or request label Mar 13, 2024
@vboulineau vboulineau changed the title Add DatadogAutoscaling resource Add DatadogPodAutoscaler resource Mar 25, 2024
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 10 times, most recently from ffd860c to 286b475 Compare April 15, 2024 15:42
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 2 times, most recently from 3bc1a3c to 2e93e67 Compare April 29, 2024 08:48
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 2 times, most recently from e5d51c3 to ec4f0a8 Compare May 7, 2024 17:02
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 4 times, most recently from 4caf4d5 to 8c696ed Compare May 16, 2024 15:58
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 5 times, most recently from e0648ef to e83dd78 Compare May 22, 2024 08:18
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 3 times, most recently from 8e1114a to 4ee3369 Compare June 20, 2024 18:43
@vboulineau vboulineau force-pushed the vboulineau/dd-autoscaling branch 3 times, most recently from 7110d8c to fe4f933 Compare July 12, 2024 12:38
@vboulineau vboulineau added this to the v1.8.0 milestone Jul 12, 2024
@vboulineau vboulineau marked this pull request as ready for review July 12, 2024 12:45
@vboulineau vboulineau requested a review from a team as a code owner July 12, 2024 12:46
Copy link
Contributor

@celenechang celenechang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but why is the skip qa label added? IMO we should QA it for the release

@vboulineau
Copy link
Contributor Author

approved, but why is the skip qa label added? IMO we should QA it for the release

We do have a dedicated QA for Autoscaling, no worries on that and there's no code in the operator to actually QA, everything is in DCA

@celenechang
Copy link
Contributor

celenechang commented Jul 12, 2024

@vboulineau OK thanks.

@vboulineau vboulineau merged commit 247d5e5 into main Jul 15, 2024
20 of 21 checks passed
@vboulineau vboulineau deleted the vboulineau/dd-autoscaling branch July 15, 2024 09:43
mftoure pushed a commit that referenced this pull request Oct 3, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants