Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] fix make task #1105

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[gitlab] fix make task #1105

merged 2 commits into from
Feb 28, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Missed a small update in #1104

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added bug Something isn't working tooling qa/skip-qa labels Feb 28, 2024
@celenechang celenechang requested review from a team as code owners February 28, 2024 16:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.93%. Comparing base (5cac5dd) to head (27f3f5e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   58.93%   58.93%           
=======================================
  Files         174      174           
  Lines       21357    21357           
=======================================
  Hits        12587    12587           
  Misses       8004     8004           
  Partials      766      766           
Flag Coverage Δ
unittests 58.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cac5dd...27f3f5e. Read the comment docs.

@celenechang celenechang merged commit 7a1b5a0 into main Feb 28, 2024
19 checks passed
@celenechang celenechang deleted the celene/fix_bundle_build branch February 28, 2024 17:22
khewonc pushed a commit that referenced this pull request Feb 28, 2024
* [gitlab] fix make task

* change to push
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* [gitlab] fix make task

* change to push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants