-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v1alpha1 deprecation log line #1099
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
+ Coverage 58.65% 58.71% +0.06%
==========================================
Files 173 173
Lines 21129 21155 +26
==========================================
+ Hits 12393 12421 +28
Misses 7984 7984
+ Partials 752 750 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
main.go
Outdated
setupLog.Error(nil, "The 'v2APIEnabled' flag is deprecated since v1.2.0+ and will be removed in a v1.7.0. "+ | ||
"Once removed, the Datadog Operator cannot be configured to reconcile the v1alpha1 DatadogAgent CRD. "+ | ||
"However, you will still be able to apply a v1alpha1 manifest with the conversion webhook enabled (using the flag 'webhookEnabled'). "+ | ||
"DatadogAgent v1alpha1 and conversion webhook hook will be removed from v1.8.0. "+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"DatadogAgent v1alpha1 and conversion webhook hook will be removed from v1.8.0. "+ | |
"DatadogAgent v1alpha1 and the conversion webhook will be removed from v1.8.0. "+ |
Co-authored-by: Celene <[email protected]>
Co-authored-by: khewonc <[email protected]>
Co-authored-by: Celene <[email protected]>
Co-authored-by: khewonc <[email protected]>
* Update v1alpha1 deprecation log line * Update main.go Co-authored-by: Celene <[email protected]> * Update main.go Co-authored-by: khewonc <[email protected]> * Update main.go Co-authored-by: Celene <[email protected]> * Update main.go Co-authored-by: khewonc <[email protected]> * Update main.go --------- Co-authored-by: Celene <[email protected]> Co-authored-by: khewonc <[email protected]>
What does this PR do?
Switched to ERROR log and indicated versions of flag and CRD deprecation, first line of Operator log when
v2APIEnabled
is set tofalse
.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label