Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v1alpha1 deprecation log line #1099

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Feb 23, 2024

What does this PR do?

Switched to ERROR log and indicated versions of flag and CRD deprecation, first line of Operator log when v2APIEnabled is set to false.

{"level":"INFO","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"Version: v1.4.0-rc.3_910ccf3f"}
{"level":"INFO","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"Build time: 2024-02-23/12:19:48"}
{"level":"INFO","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"Git Commit: 910ccf3"}
{"level":"INFO","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"Go Version: go1.19.13"}
{"level":"INFO","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"Go OS/Arch: linux/arm64"}
{"level":"ERROR","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"The 'v2APIEnabled' flag is deprecated since v1.2.0+ and will be removed in a v1.7.0. Once removed, the Datadog Operator cannot be configured to reconcile the v1alpha1 DatadogAgent CRD. However, you will still be able to apply a v1alpha1 manifest with the conversion webhook enabled (using the flag 'webhookEnabled'). DatadogAgent v1alpha1 and conversion webhook hook will be removed from v1.8.0. See migration page for more details https://docs.datadoghq.com/containers/guide/datadogoperator_migration/"}
{"level":"INFO","ts":"2024-02-23T17:23:01Z","logger":"setup","msg":"Manager will be watching namespace","namespace":"system"}

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m added the documentation Improvements or additions to documentation label Feb 23, 2024
@levan-m levan-m added this to the v1.5.0 milestone Feb 23, 2024
@levan-m levan-m requested review from a team as code owners February 23, 2024 17:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.71%. Comparing base (bb82660) to head (4f6058f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
+ Coverage   58.65%   58.71%   +0.06%     
==========================================
  Files         173      173              
  Lines       21129    21155      +26     
==========================================
+ Hits        12393    12421      +28     
  Misses       7984     7984              
+ Partials      752      750       -2     
Flag Coverage Δ
unittests 58.71% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb82660...4f6058f. Read the comment docs.

main.go Outdated Show resolved Hide resolved
main.go Outdated
setupLog.Error(nil, "The 'v2APIEnabled' flag is deprecated since v1.2.0+ and will be removed in a v1.7.0. "+
"Once removed, the Datadog Operator cannot be configured to reconcile the v1alpha1 DatadogAgent CRD. "+
"However, you will still be able to apply a v1alpha1 manifest with the conversion webhook enabled (using the flag 'webhookEnabled'). "+
"DatadogAgent v1alpha1 and conversion webhook hook will be removed from v1.8.0. "+
Copy link
Contributor

@celenechang celenechang Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"DatadogAgent v1alpha1 and conversion webhook hook will be removed from v1.8.0. "+
"DatadogAgent v1alpha1 and the conversion webhook will be removed from v1.8.0. "+

main.go Outdated Show resolved Hide resolved
Co-authored-by: Celene <[email protected]>
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
levan-m and others added 3 commits February 23, 2024 14:24
Co-authored-by: khewonc <[email protected]>
Co-authored-by: Celene <[email protected]>
Co-authored-by: khewonc <[email protected]>
main.go Outdated Show resolved Hide resolved
@levan-m levan-m merged commit 3bfd043 into main Feb 23, 2024
19 checks passed
@levan-m levan-m deleted the levan-m/v1alpha1-deprecation branch February 23, 2024 20:29
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* Update v1alpha1 deprecation log line

* Update main.go

Co-authored-by: Celene <[email protected]>

* Update main.go

Co-authored-by: khewonc <[email protected]>

* Update main.go

Co-authored-by: Celene <[email protected]>

* Update main.go

Co-authored-by: khewonc <[email protected]>

* Update main.go

---------

Co-authored-by: Celene <[email protected]>
Co-authored-by: khewonc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants