Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(golangci-lint): bump from v1.51.0 to v1.56.0 #1075

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Feb 8, 2024

What does this PR do?

Bump golangci-lint version from v1.51.0 to v1.56.0

Motivation

The current version of golangci-lint has memory issues with some Go versions.

Describe your test plan

➜  datadog-operator git:(wassim.dhif/bump-golangci-lint) ✗ make lint
hack/golangci-lint.sh -b "bin/darwin-arm64" v1.56.0
golangci/golangci-lint info checking GitHub for tag 'v1.56.0'
golangci/golangci-lint info found version: 1.56.0 for v1.56.0/darwin/arm64
golangci/golangci-lint info installed bin/darwin-arm64/golangci-lint
go fmt ./...
go vet ./...
bin/darwin-arm64/golangci-lint run ./...
pkg/config/config.go:12:2: import 'github.com/go-logr/logr' is not allowed from list 'Main' (depguard)
	"github.com/go-logr/logr"
	^
[...]
controllers/datadogagent/clusteragent.go:1459:18: fmt.Sprintf can be replaced with string addition (perfsprint)
			MatchPattern: fmt.Sprintf("*-app.agent.%s", site),
			              ^
make: *** [lint] Error 1

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@wdhif wdhif force-pushed the wassim.dhif/bump-golangci-lint branch from 0157cc1 to d7ec94b Compare February 8, 2024 10:06
@wdhif wdhif merged commit 77c379f into main Feb 8, 2024
19 checks passed
@wdhif wdhif deleted the wassim.dhif/bump-golangci-lint branch February 8, 2024 12:42
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants