Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLI metrics URL to clc rbac #1072

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

jennchenn
Copy link
Member

@jennchenn jennchenn commented Feb 7, 2024

What does this PR do?

As a follow-up to #910, we want to be able to query the SLI metrics URL from cluster check runners as well.

Motivation

This change is necessary to support the corresponding changes to the control plane checks to support SLI metrics.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  1. make build
  2. make docker-build
  3. make deploy
  4. I then applied a manifest with cluster check workers enabled, and verified that the datadog-cluster-checks-runner cluster role changes were applied appropriately

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@jennchenn jennchenn added the enhancement New feature or request label Feb 7, 2024
@jennchenn jennchenn added this to the v1.5.0 milestone Feb 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6f5b5c5) 58.58% compared to head (d6d8332) 58.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   58.58%   58.57%   -0.01%     
==========================================
  Files         166      166              
  Lines       20513    20516       +3     
==========================================
  Hits        12018    12018              
- Misses       7767     7770       +3     
  Partials      728      728              
Flag Coverage Δ
unittests 58.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...adogagent/component/clusterchecksrunner/default.go 0.69% <0.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5b5c5...d6d8332. Read the comment docs.

@jennchenn jennchenn marked this pull request as ready for review February 7, 2024 19:22
@jennchenn jennchenn requested review from a team as code owners February 7, 2024 19:22
@celenechang celenechang merged commit c4be0e1 into main Feb 22, 2024
19 checks passed
@celenechang celenechang deleted the jenn/add-metrics-slis-url-clc branch February 22, 2024 15:03
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants