-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm check feature #1060
Add helm check feature #1060
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
+ Coverage 58.56% 58.68% +0.12%
==========================================
Files 166 169 +3
Lines 20533 20644 +111
==========================================
+ Hits 12025 12115 +90
- Misses 7782 7799 +17
- Partials 726 730 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions
LGTM, needs just one small fix. |
* Add helm check feature * fix tests and imports * fix comment typo * Apply docs review suggestions * apply review suggestions/remove customConf * newline * add more tests * apply review suggestions * fix flaky configmap tests
What does this PR do?
Add support for the helm check in the operator DatadogAgent v2alpha1 CRD
Motivation
Customer request, improve ease of configurability of the helm check
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
features.helmCheck.enabled
:features.helmCheck.collectEvents
:features.helmCheck.valuesAsTags
:Describe your test plan
features.helmCheck.collectEvents: true
features.helmCheck.valuesAsTags
For each test scenario:
cluster_check: true
, otherwisecluster_check: false
Validate Defaults
features.helmCheck.enabled: true
:Install any helm chart e.g.
helm install my-release oci://registry-1.docker.io/bitnamicharts/mysql
Verify that the cluster agent is deployed and runs the helm check:
kubectl get configmap datadog-helm-check-config -oyaml
kubectl get clusterrole system-datadog-helm-check-dca -oyaml
roleRef.Name
is correct (system-datadog-helm-check-dca
)kubectl get clusterrolebinding system-datadog-helm-check-dca -oyaml
helm.release
metric is collected in the Datadog metrics explorerValidate defaults with clusterChecksRunners
See
cluster_check: true
system-datadog-helm-check-ccr
roleRef.Name
should besystem-datadog-helm-check-ccr
Validate
features.helmCheck.collectEvents: true
Verify steps 3-6 from above the above
Defaults
. Everything should remain unchanged expect for the configmap:Verify that helm metrics are still collected in the metrics explorer and helm events are collected in the Datadog Events Explorer
Repeat with the CCR enabled in the dda. Everything should remain the same as clusterChecksRunners except the configmap should have
cluster_check: true
and the RBAC names aresystem-datadog-helm-check-ccr
.Validate
features.helmCheck.valuesAsTags
Validate steps 2-6 from above "Validate
features.helmCheck.collectEvents
" steps. Everything should remain the same except for the configmap contents.Verify that helm metrics are collected with the new tags in the metrics explorer. Verify that events are collected and have the new tags in the Datadog Events Explorer
Repeat with CCR enabled in the dda. Everything should remain the same except the configmap should have
cluster_check: true
and the RBAC names aresystem-datadog-helm-check-ccr
.Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label